Repository navigation
ci: a release goes public only once every artifact is up - #387
Merged
Merged
Conversation
The publish job lifted the draft as soon as the macOS and Linux jobs exited 0, and its comment claimed that meant every artifact was up. It now runs scripts/check-release-assets.sh first: every file a release of that tag should carry has to be listed by name, finished uploading and not empty, or the release stays a draft and the job says which file is missing. The macOS job's other branch, for a release that already exists, uploaded straight into it while it was public, so the page offered a partial set until the Linux jobs finished. It now turns the release back into a draft before uploading, so both branches keep it hidden until the check passes. Publishing a draft defaults to making it Latest, which would let a re-run of an older tag take Latest from a newer one, so the lift goes through the API with make_latest=legacy: a new release still becomes Latest, a re-published old one does not. The check is a script so it can be run by hand against any release: against v0.23.0 it passes with all five files, against v0.18.0 it names the four Linux files that release never had. CI runs its self-test, which covers a missing file, an unfinished upload, an empty file and another version's files, each asserting which file was reported, and compares its architectures with release.yml's matrix.
sepehr-safari
deleted the
the-release-lifts-only-when-its-files-are-up
branch
September 25, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #362. Notary has the same two claims word for word and gets the same change in its own pull request, which closes the issue.
publishrunsscripts/check-release-assets.shbefore lifting the draft. Each expected file must be listed by name, havestate == uploadedand a non-zero size; otherwise the release stays a draft and the step names what is missing. It fails closed: ifgherrors, the check sees no input and refuses.gh apiwithdraft=false(typed boolean) andmake_latest=legacy. A plain--draft=falsecounts as a new publish and defaults to making that release Latest, so re-running an older tag would have moved/releases/latest(both installers and the in-app update check) back a version.legacypicks Latest by version and date.Verified:
/bin/bash3.2 and shellcheck clean{"draft": false, "make_latest": "legacy"}Not verifiable before a real release: the check and the lift against a draft. Both fail closed (the release stays a draft), and the next release is the first run.