Skip to content

feat(native): add structured notification protocol - #153

Draft
777genius wants to merge 1 commit into
mainfrom
feat/agent-notify-native-protocol
Draft

777genius wants to merge 1 commit into
mainfrom
feat/agent-notify-native-protocol

Conversation

@777genius

Copy link
Copy Markdown
Owner

Literal --help in notification content currently selects CLI help and exits successfully without sending. Parse options by position and introduce a versioned native request/receipt protocol with strict validation, per-attempt file ownership, and side-effect-free capability discovery.

This is the first bounded checkpoint of agent-initiated notifications. Existing hooks and legacy click actions retain their behavior. The new protocol advertises only none; installer activation, Codex routing, the journal and MCP tools follow in dependent PRs.

Validation:

  • 48 macOS Swift package tests passed before the Unicode review fix; all 11 native protocol tests passed after that fix.
  • Go nativeprotocol tests passed, including shared Swift wire fixtures.
  • Standalone native subprocess smoke passed, including literal flags, correlated rejection receipts, duplicate launches, symlink rejection and joined Unicode; no notifications sent.
  • Independent Astra review found one Unicode validation issue, fixed with byte-preserving emoji/ZWNJ regressions. Full installed Desktop E2E and upgrade/cold-start qualification remain later gates.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

777genius added a commit that referenced this pull request Sep 11, 2026
Integrate current main into the draft candidate. Related to the narrow help-dispatch issue covered by PR #153; no native-protocol features are included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant