Skip to content

fix(notify): capability-aware default MCP configure - #185

Draft
777genius wants to merge 1 commit into
feat/agent-notify-e2efrom
cursor/uap-installer-r0-configure-6c84
Draft

777genius wants to merge 1 commit into
feat/agent-notify-e2efrom
cursor/uap-installer-r0-configure-6c84

Conversation

@777genius

Copy link
Copy Markdown
Owner

This is the remaining R0/P0 follow-up for #177: truthful, capability-aware agent-notify configure. It does not add the UAP SDK, wizard, or portable asset.

Behavior

  • Auto-default MCP is on only where this installer can actually configure it (macOS).
  • On Linux/Windows, auto-default keeps hooks-only setup, prints unsupported_platform, and does not call that a full MCP installation. Bootstrap still exits 0 for that skip.
  • Explicit --agent-notify without a supported OS or setup-notifications API is incomplete/nonzero. Committed hooks/plugin install are not rolled back.
  • If the capability exists and configure fails, bootstrap/setup-codex/init.md return incomplete/nonzero with a retry command. Previously this was warning + exit 0.
  • --skip-agent-notify remains hooks-only.

setup-codex now distinguishes auto vs explicit --agent-notify. Direct configure still owns the macOS-only setup contract; this PR only stops advertising a full MCP install when that contract cannot run.

Tests

  • go test ./cmd/claude-notifications -run 'TestNotificationBootstrapOffline|TestNotificationInitOfflineBranch|TestNotificationConfigureParserAndSetupOptIn|TestSetupCodexE2E'
  • bash -n bin/bootstrap.sh && bash bin/bootstrap_product_test.sh
Open in Web Open in Cursor 

Auto-default skips agent-notify MCP on unsupported OS or an old CLI and
keeps hooks-only success. Explicit --agent-notify and a failed configure
of a supported capability now return incomplete/nonzero without rolling
back committed hooks.

Co-authored-by: Илия <iliyazelenkog@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.06%. Comparing base (89d8524) to head (cd6c672).

Files with missing lines Patch % Lines
cmd/claude-notifications/setup_codex.go 25.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/agent-notify-e2e     #185      +/-   ##
=========================================================
- Coverage                  65.27%   65.06%   -0.21%     
=========================================================
  Files                        168      168              
  Lines                      17182    17198      +16     
=========================================================
- Hits                       11215    11190      -25     
- Misses                      4360     4402      +42     
+ Partials                    1607     1606       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants