Conversation
Auto-default skips agent-notify MCP on unsupported OS or an old CLI and keeps hooks-only success. Explicit --agent-notify and a failed configure of a supported capability now return incomplete/nonzero without rolling back committed hooks. Co-authored-by: Илия <iliyazelenkog@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/agent-notify-e2e #185 +/- ##
=========================================================
- Coverage 65.27% 65.06% -0.21%
=========================================================
Files 168 168
Lines 17182 17198 +16
=========================================================
- Hits 11215 11190 -25
- Misses 4360 4402 +42
+ Partials 1607 1606 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the remaining R0/P0 follow-up for #177: truthful, capability-aware agent-notify configure. It does not add the UAP SDK, wizard, or portable asset.
Behavior
unsupported_platform, and does not call that a full MCP installation. Bootstrap still exits 0 for that skip.--agent-notifywithout a supported OS orsetup-notificationsAPI is incomplete/nonzero. Committed hooks/plugin install are not rolled back.setup-codex/init.mdreturn incomplete/nonzero with a retry command. Previously this was warning + exit 0.--skip-agent-notifyremains hooks-only.setup-codexnow distinguishes auto vs explicit--agent-notify. Direct configure still owns the macOS-only setup contract; this PR only stops advertising a full MCP install when that contract cannot run.Tests
go test ./cmd/claude-notifications -run 'TestNotificationBootstrapOffline|TestNotificationInitOfflineBranch|TestNotificationConfigureParserAndSetupOptIn|TestSetupCodexE2E'bash -n bin/bootstrap.sh && bash bin/bootstrap_product_test.sh