Repository navigation
Conversation
高級 is a general adjective in Taiwan (高級中學, 高級餐廳, 高級會員), so the generic 高級 -> 高階 rule over-converts. Put the identity first so s2twp keeps 高級, and keep explicit Taiwan IT terms as phrases: 高級設置 -> 進階設定 and 高級選項 -> 進階選項 (existing), plus 高級語言 -> 高階語言 and 高級搜索 -> 進階搜尋. TWPhrasesRev gains the matching reverse entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正 #1313 中「高級 / 高階 / 進階」一項。
問題:
TWPhrases.txt的高級 高階 進階 高級會把所有「高級」轉成「高階」,例如高级中学 → 高階中學、高级餐厅 → 高階餐廳。在臺灣,「高級」是通用形容詞,法規名稱即為《高級中等教育法》;「高階」「進階」只用於特定術語。修改:
高級 高級 高階 進階,s2twp 預設保留「高級」,反向對照仍完整(DictionaryReverseMappingTest)。高級設置 → 進階設定、高級選項 → 進階選項,新增高級語言 → 高階語言、高級搜索 → 進階搜尋,並在TWPhrasesRev.txt補上對應反向條目。s2twp、tw2sp測試案例。依據:
已知影響:
高级函数由「高階函式」變為「高級函式」。大陸用法中「高級函數」常指 Excel 等的進階函數,語意不一,依「疑義從無」原則不另收錄。測試:本機以官方 Python 套件載入修改後的文字詞典,模擬
s2twp、tw2sp設定,跑testcases.json中全部相關案例:修改前新案例失敗,修改後 142/142 通過;詞典排序與正反向完整性亦已檢查。完整 Bazel 測試待 CI 確認。本 PR 在 AI 工具(Claude Code)協助下撰寫;用字判斷由我(臺灣使用者)確認。