Skip to content

Campaign: v4.10.0 review fixes and native monitoring removal - #629

Merged
Calmingstorm merged 162 commits into
masterfrom
campaign/v4.10.0-review
Sep 30, 2026
Merged

Calmingstorm merged 162 commits into
masterfrom
campaign/v4.10.0-review

Conversation

@Calmingstorm

@Calmingstorm Calmingstorm commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Scope

All 200 in-scope v4.10.0 review issues plus clean removal of native Grafana and Prometheus integrations. No native Loki integration existed; external MCP integrations remain unchanged.

Implementation ledger

See docs/reviews/v4.10.0-campaign.md for every issue, original implementation commit, regression files and notes. All 200 lanes have implementations; none remains blocked on a product decision. The approved #490 switchover makes odin the API client on every install, with old server arguments refused before network dispatch and migration guidance to odin-server.

Validation

Stable integrated code/test snapshot 82b3cc9: full suite 22,060 passed, 24 skipped, zero failures/errors. Coverage gate: zero findings, 94.5% aggregate reported. Lint and type ratchets: zero new findings (two existing type diagnostics retained). Config apply classification: zero findings. npm run check and production UI rebuild passed; generated references refreshed. See docs/reviews/v4.10.0-campaign-gates.md for evidence and limits. Later ledger-only edits document these results.

Constraints and limits

No master merge, deployment, Odin restart, release-pipeline dispatch, issue closure or live configuration mutation. Existing configuration compatibility retained. Numerical coverage ratchets unchanged; only entries for physically deleted monitoring modules removed. Platform skips and suite warnings remain explicit; no live-install qualification is claimed. No attribution trailers.

@Calmingstorm

Copy link
Copy Markdown
Owner Author

Round 1 corrections completed at 3047c46. Implementation map: docs/reviews/v4.10.0-campaign-round1.md.

Final hosted verification (run 36662254094): plain and instrumented suites each 22,116 passed / 25 skipped; coverage 94.5%, findings=0; lint/type new=0; configuration classification findings=0. UI check/build and browser-network guard passed. Deploy skipped. Local lint, types, configuration classification and npm run check also passed. No ratchet edits.

Initial parent local full runs each had 22,114 passed / 24 skipped and two failures: the stale remote-supervisor empty=False expectation (both runs), a nondeterministic recovery-wait cancellation test (coverage), and one local supervisor-ownership-loss overflow test (plain). The stale assertion was replaced with stronger live-escapee/caveat proof at 7db8c15; the cancellation test now uses a controlled recovery clock and cancellation at actual wait entry at 3047c46. The overflow ownership-loss event could not be reproduced or attributed to a demonstrated product bug: its standalone file passed 11 tests, and bounded diagnostic probes passed 100 clean exits plus 8 concurrent overflow/quota cases. Its unknown outcome remains correctly fenced; this is an unresolved local supervisor reliability caveat, not proof of flake freedom or a reason to weaken cleanup checks.

F6 safety limitation: old PDF imports never retained original URL provenance. Exact durable text can be safely reused without duplication; changed or unverifiable basename content needs an explicit source choice, reported as an actionable conflict, rather than silently overwriting a possibly unrelated document.

No merge, deploy, restart, release-pipeline dispatch, live mutation or issue closure.

@Calmingstorm
Calmingstorm merged commit 99ffd44 into master Sep 30, 2026
14 of 15 checks passed
@Calmingstorm
Calmingstorm deleted the campaign/v4.10.0-review branch September 30, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant