ticker: fix follow-up for initial seed + display reset - #1259
Merged
Conversation
Follow-up to #1258. The initial fix rejected future ticks above the ceiling but left two paths for the garbage to stick: 1. useState was seeded with the raw value on mount, so the very first render painted 8.26e79 before any effect ran. The monotonic guard then rejected every healthy value that followed as a down tick. 2. Even after flushing lastRef, the display state still held the garbage, and the raf tick was returning early on lastRef=null so setDisplay was never called with a smaller-but-healthy value. Fix: guard the useState seed too, and reset display to undefined when an above-ceiling value arrives. A subsequent healthy push then seeds both lastRef and display fresh.
Flotapponnier
force-pushed
the
fix/ticker-sanity-clamp
branch
from
July 17, 2026 13:15
89d1bb0 to
b3b5c15
Compare
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1258. First fix left the initial useState seed unguarded and never reset display when a poisoned value came in. Now both paths are covered.