Repository navigation
Remove the legacy launcher and in-game menu UI, keep every system - #184
Merged
Merged
Conversation
The launcher's visual UI is deleted so a new UI can be dropped in; every system it sat on is kept. Nothing here changes a mod, engine or settings behaviour - only the chrome that drew them. Launcher UI - delete the 12 screens, the widget kit, the nav/rail shell, the tabs and the splash art; 94 layouts -> 20 (the kept 20 are the in-game HUD/game host overlays that ARE the mod systems) - keep 7 placeholder Activities (BaseActivity + Main/Splash/Library/ Settings/ModsFullscreen/Crash) as manifest/Intent targets; they draw nothing - delete the dead legacy drawables (splash_bg_*, launch_bg_*, dock/nav) and the dead Widget.Caramel.NavTab/NavRailTab/QuickDock styles - keep the reusable token/style system (UiTokens, Widget.Caramel.Card*, TextAppearance.Caramel.*, GlowDimens, generic bg_*/ic_*) In-game Mod Menu UI - bump the sweetloader submodule to chore/remove-in-game-menu, which drops the native Dear ImGui menu (src/pl/menu/*, third_party/imgui/) - drop the Java bridge wiring from MinecraftActivity and the overlay manager; the mod systems themselves are untouched Tests - trim the two tests that pinned the deleted button drawables (ButtonPressDrawableTest, RadiusScaleTest) - refresh the findViewById hygiene baseline (32 -> 29)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The launcher's entire visual UI and the in-game Mod Menu UI are removed so a new UI can be dropped in later. Every system they sat on — engine, core managers, settings, mod systems — is kept and still compiles. This PR changes chrome only: no mod, engine or settings behaviour moves.
Net: ~112,000 lines deleted across the parent repo and the
sweetloadersubmodule.Before → after
The 20 kept layouts are the in-game HUD / game-host overlays — they are the mod systems, not launcher chrome. The 7 kept Activities (
BaseActivity+Main/Splash/Library/Settings/ModsFullscreen/Crash) exist only as manifest andIntenttargets; they draw nothing.Scope
Launcher UI — delete the 12 screens, the widget kit, the nav/rail shell, the tabs and the splash art; delete the dead legacy drawables (
splash_bg_*,launch_bg_*,bg_launch_*,bg_dock_*,ic_nav_*,nav_*) and the deadWidget.Caramel.NavTab/.NavRailTab/.QuickDock*styles.In-game Mod Menu UI — the menu had three layers and all three are cut:
src/pl/menu/*,third_party/imgui/, thepl::menu::Framecall inPresentFrameEffect::OnPresentBoundary, theimguiCMake target + link, theNOTICEattributionMinecraftActivity.ktwiring,InbuiltOverlayManagereditor stateDebugMenuOverlayis the F3 overlay mod, not the menu — it stays.Kept on purpose (a new UI will reuse them):
UiTokens,Widget.Caramel.Card*,TextAppearance.Caramel.*,GlowDimens, the genericbg_*/ic_*drawables,PersonalizationManager, and everycore.*system.Submodule pin
sweetloaderis bumped fromfac14a2to3fda389on branchchore/remove-in-game-menu(its own PR is open separately). The pin is a commit, soscripts/check_submodules.shstays green.Tests
Two tests pinned drawables this PR deletes; both were trimmed, not deleted:
ButtonPressDrawableTest— now checks only the survivingbutton_accent.xmlRadiusScaleTest— dropped the three removed surfaces from its listThe findViewById hygiene baseline is refreshed (32 → 29).
Verification
./gradlew :app:testDebugUnitTest./gradlew :app:lintDebug./gradlew :app:assembleDebug.cxxrebuild, produceslibsweetloader.so)scripts/check_ui_hygiene.pytests/cosmetics/run_tests.shcheck_sources_listed.py/check_pinned_deps.py