Skip to content

Fix: accept Windows' refused-connection wording in the isolation test - #535

Merged
0xLeif merged 1 commit into
mainfrom
0xleif/fix/isolation-windows-refused
Sep 26, 2026
Merged

0xLeif merged 1 commit into
mainfrom
0xleif/fix/isolation-windows-refused

Conversation

@0xLeif

@0xLeif 0xLeif commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • default_temp_env_points_github_at_a_dead_port failed on test (windows-latest) in the v1.8.0 release PR chore: release v1.8.0 #532. The error: io: no connection could be made because the target machine actively refused it. (os error 10061).
  • Cause: chore: release v1.8.0 #532's lockfile moves ureq from 3.3.0 to 3.4.2. ureq 3.3.0 replaced every refused connect with a synthetic "Connection refused", so every OS printed the same words. ureq 3.4 passes the OS error through (last_err in transport/tcp.rs). Linux and macOS still say Connection refused (os error 111/61), but Windows now uses WSAECONNREFUSED's own text. main is green only because it still pins ureq 3.3.0. Any lockfile refresh brings this failure in.
  • Fix: accept actively refused / os error 10061 alongside connection refused. Both halves of the proof stay: the child's GitHub base must start with http://127.0.0.1:, and the failure must be a refusal. A bare failed still doesn't count, so a real api.github.com failure still fails the test.
  • Adds the SpecSync change record accept-windows-refused-connection-wording-in-the-isolation-test (bug-fix, no spec change). It's a draft awaiting definition approval. specsync change check --strict --require-coverage 100 and lifecycle enforce --all pass with it present.
  • Addresses corvid-agent's CHANGES_REQUESTED on chore: release v1.8.0 #532 (option 1: widen the assertion). The Windows matrix cell stays.

Test Plan

  • fledge run test -- --test isolation on main's lockfile (ureq 3.3.0), macOS: 4 passed
  • Same test on chore: release v1.8.0 #532's lockfile (ureq 3.4.2), macOS: 4 passed
  • Spawned-binary stderr observed: 3.3.0 prints io: Connection refused, 3.4.2 prints io: Connection refused (os error 61)
  • fledge lanes run verify (fmt, lint, test, build, spec-check, validate-templates) passes
  • fledge trust verify --range origin/main..HEAD passes (augur: proceed, risk 18)
  • test (windows-latest) green here with ureq 3.3.0 (run 36257383427)
  • test (windows-latest) green with ureq 3.4.2 (run 36257571327). That run was a workflow_dispatch probe of main + this fix + chore: release v1.8.0 #532's release commit. The log shows Compiling ureq v3.4.2 then default_temp_env_points_github_at_a_dead_port ... ok
  • SpecSync: definition approval → change check → scoped review → change finalize, before merge

🤖 Generated with Claude Code

https://claude.ai/code/session_01V3ZZAEiUP7xRJPozhZb6rL

default_temp_env_points_github_at_a_dead_port recognized a refused
connection only by the words "connection refused". ureq 3.3.0
synthesized exactly that message on every platform. ureq 3.4 passes
the OS error through instead, so Windows now reports WSAECONNREFUSED's
"No connection could be made because the target machine actively
refused it. (os error 10061)" and the test failed on the v1.8.0
release PR (#532), whose lockfile carries ureq 3.4.2.

Accept "actively refused" and "os error 10061" as well. The loopback
assertion on the child's GitHub base is unchanged, and a generic
"failed" still does not count, so a real api.github.com failure still
fails the test.

Adds the SpecSync change record (draft, awaiting definition approval).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V3ZZAEiUP7xRJPozhZb6rL
@0xLeif
0xLeif requested a review from a team as a code owner September 26, 2026 16:58
@0xLeif
0xLeif requested review from 0xGaspar, Kyntrin, corvid-agent and tofu-ux and removed request for a team September 26, 2026 16:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T17:01:20.185280Z 0cda5e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Your code sparkles like a dropped french fry."

CI Summary

Check Status
Dependency Audit ✅ Passed
Integration (3 OS) ✅ Passed
Lint (fmt + clippy) ✅ Passed
Spec Validation ✅ Passed
Tests (3 OS) ✅ Passed

Powered by corvid-pet

@0xLeif
0xLeif merged commit 260063a into main Sep 26, 2026
22 checks passed
@0xLeif
0xLeif deleted the 0xleif/fix/isolation-windows-refused branch September 26, 2026 17:19
@0xLeif 0xLeif mentioned this pull request Sep 26, 2026
5 tasks
0xLeif added a commit that referenced this pull request Sep 26, 2026
Rebasing onto main brought in four commits the section did not list:
#531, #533, #534 and #535. Add them where fledge's generator places
them.

Also drop the stale "## Unreleased" block. Both of its bullets describe
#520 (c4abcb2), which ships in 1.8.0, so they move under that entry as
sub-bullets instead of being advertised as unreleased. `fledge release`
inserts the new section above an existing Unreleased block rather than
consuming it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V3ZZAEiUP7xRJPozhZb6rL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant