Fix: accept Windows' refused-connection wording in the isolation test - #535
Merged
Merged
Conversation
default_temp_env_points_github_at_a_dead_port recognized a refused connection only by the words "connection refused". ureq 3.3.0 synthesized exactly that message on every platform. ureq 3.4 passes the OS error through instead, so Windows now reports WSAECONNREFUSED's "No connection could be made because the target machine actively refused it. (os error 10061)" and the test failed on the v1.8.0 release PR (#532), whose lockfile carries ureq 3.4.2. Accept "actively refused" and "os error 10061" as well. The loopback assertion on the child's GitHub base is unchanged, and a generic "failed" still does not count, so a real api.github.com failure still fails the test. Adds the SpecSync change record (draft, awaiting definition approval). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V3ZZAEiUP7xRJPozhZb6rL
0xLeif
requested review from
0xGaspar,
Kyntrin,
corvid-agent and
tofu-ux
and removed request for
a team
September 26, 2026 16:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Caw! Your code sparkles like a dropped french fry."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ✅ Passed |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
0xLeif
added a commit
that referenced
this pull request
Sep 26, 2026
Rebasing onto main brought in four commits the section did not list: #531, #533, #534 and #535. Add them where fledge's generator places them. Also drop the stale "## Unreleased" block. Both of its bullets describe #520 (c4abcb2), which ships in 1.8.0, so they move under that entry as sub-bullets instead of being advertised as unreleased. `fledge release` inserts the new section above an existing Unreleased block rather than consuming it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V3ZZAEiUP7xRJPozhZb6rL
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_temp_env_points_github_at_a_dead_portfailed ontest (windows-latest)in the v1.8.0 release PR chore: release v1.8.0 #532. The error:io: no connection could be made because the target machine actively refused it. (os error 10061)."Connection refused", so every OS printed the same words. ureq 3.4 passes the OS error through (last_errintransport/tcp.rs). Linux and macOS still sayConnection refused (os error 111/61), but Windows now uses WSAECONNREFUSED's own text.mainis green only because it still pins ureq 3.3.0. Any lockfile refresh brings this failure in.actively refused/os error 10061alongsideconnection refused. Both halves of the proof stay: the child's GitHub base must start withhttp://127.0.0.1:, and the failure must be a refusal. A barefailedstill doesn't count, so a real api.github.com failure still fails the test.accept-windows-refused-connection-wording-in-the-isolation-test(bug-fix, no spec change). It's a draft awaiting definition approval.specsync change check --strict --require-coverage 100andlifecycle enforce --allpass with it present.Test Plan
fledge run test -- --test isolationonmain's lockfile (ureq 3.3.0), macOS: 4 passedio: Connection refused, 3.4.2 printsio: Connection refused (os error 61)fledge lanes run verify(fmt, lint, test, build, spec-check, validate-templates) passesfledge trust verify --range origin/main..HEADpasses (augur: proceed, risk 18)test (windows-latest)green here with ureq 3.3.0 (run 36257383427)test (windows-latest)green with ureq 3.4.2 (run 36257571327). That run was aworkflow_dispatchprobe ofmain+ this fix + chore: release v1.8.0 #532's release commit. The log showsCompiling ureq v3.4.2thendefault_temp_env_points_github_at_a_dead_port ... okchange check→ scoped review →change finalize, before merge🤖 Generated with Claude Code
https://claude.ai/code/session_01V3ZZAEiUP7xRJPozhZb6rL