Repository navigation
fix(proxies): let fenced tunnels resolve names by giving them the fence's DNS - #270
Merged
Merged
Conversation
sidecarCreate picked the fenced network itself and skipped isolate(), so a tunnel on the fence kept the daemon's resolvers, which the fence drops. It now goes through isolate() like every bridge earner.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 77.29% 77.29% -0.01%
==========================================
Files 81 81
Lines 12567 12565 -2
==========================================
- Hits 9714 9712 -2
Misses 2048 2048
Partials 805 805
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With LAN isolation on, a proxied earner's tunnel joins the fenced network, but it never got the fence's public resolvers (1.1.1.1 and 9.9.9.9). Every other fenced container gets them through
isolate(); the tunnel's create options picked the network by hand and skipped that call. The fence drops the daemon's LAN resolver, so the tunnel was left with resolvers it cannot reach.sidecarCreatenow builds its host config onbridgeand passes it throughisolate(), the same path as every bridge earner. With isolation off, the tunnel stays on the default bridge with the daemon's resolvers, as before.Test:
TestFencedSidecarGetsTheFencesDNSfailed on main (DNS [], want the fence's [1.1.1.1 9.9.9.9]) and passes here.go test ./internal/runtime/ ./internal/services/passes.Web had the same gap in
sidecar_kwargs; fixed in GeiserX/CashPilot#649.