Repository navigation
feat(i18n): translate GUI navigation, playback and onboarding - #939
Conversation
Translate the browser frontend's navigation, playback, library overview, source onboarding and podcast controls into both Chinese scripts, including the visualizer hint, settings and library filters and the announcements panel added on main since the series was drafted. Entries for GUI fields main no longer has are left out.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add Chinese GUI strings src/core/i18n/gui/zh_hans.rs, src/core/i18n/gui/zh_hant.rs |
The locale definitions add translated GUI labels, messages, and formatted text for Simplified and Traditional Chinese. Unspecified fields continue to use English fallback values. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- LargeModGames/spotatui#933: Adds Simplified and Traditional Chinese translations for infrastructure, recap, and tool strings in the same locale rollout.
- LargeModGames/spotatui#923: Adds Simplified and Traditional Chinese translations for application and runtime status strings.
- LargeModGames/spotatui#929: Adds Simplified and Traditional Chinese translations for infrastructure status strings.
Merge Risk: 
Minimal · up to da792
-
No concrete merge-blocking risk is identified in the supplied translation changes.
Pre-merge checks: 
4
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
The tenth Chinese translation PR (refs #726), the first of the GUI table: the browser frontend's navigation, playback, library overview, source onboarding and podcast controls in Simplified Chinese (
zh-Hans) and Traditional Chinese with Taiwan wording (zh-Hant).src/core/i18n/gui/zh_hans.rs,zh_hant.rs: 214 of the GUI table's 510 strings. That includes 13 that came in onmainafter the series was drafted and fit this part of the page: the visualizer hint, "Shuffle {name}", the settings and library filters with their empty states, and the announcements and changelog panel...ENand comes in the next two PRs.gui/src/bindings/strings.jsonis regenerated.English is unchanged.
Testing
macOS (aarch64), on top of
1e25bec6:cargo fmt --all --check: clean.cargo clippy --locked -- -D warnings: clean on slim (telemetry,tui) and default.cargo test --locked: slim 1778 passed; default pluslocal-files,subsonic2382 passed, 21 ignored; the gui feature set with the five sources 2202 passed, 30 ignored.gui/:npm test540 passed (61 files);npm run typecheckandnpm run lintclean.Not run: the Linux-only
all-sourcesleg (PipeWire), which CI covers.Additional notes
A native-speaker review of the wording is welcome; any fix is a one-line change in the table.
Summary by CodeRabbit