Added image and updated description for Bhavya Shah#7
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the student profile for Bhavya Shah and significantly revises the README documentation to change the contribution workflow from a clone-based to a fork-based approach.
Changes:
- Updated Bhavya Shah's profile in students.yml with full name, website, custom photo, education details, and joining semester
- Restructured README's "Getting Started" section to use a fork-based workflow instead of direct cloning
- Added bhavya.jpg image to the teampic directory
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| _data/students.yml | Updated Bhavya Shah's profile with complete information including full name, ASU profile link, custom photo, education history, and Spring 2026 join date |
| README.md | Converted Getting Started instructions from clone-based to fork-based workflow, removing local Jekyll setup instructions and consolidating Git workflow documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Bhavya Minesh Shah | ||
| website: https://search.asu.edu/profile/5016411 | ||
| photo: bhavya.jpg |
There was a problem hiding this comment.
The PR description mentions "images/teampics/bhavya.jpg" (with 's'), but the actual directory is "images/teampic/" (without 's'). Additionally, it mentions "students.yaml" but the actual file is "students.yml". While these are documentation issues in the PR description rather than the code, they should be noted for accuracy.
| --- | ||
|
|
||
| ## Getting Started (Clone & Run Locally) | ||
| ## Getting Started (Fork & Add) |
There was a problem hiding this comment.
The Table of Contents at line 12 references "Git Workflow (Branches & Pull Requests)" section but this section no longer exists in the document. The content appears to have been merged into the "Getting Started" section. The Table of Contents should be updated to reflect the current document structure.
| --- | ||
|
|
||
| ## Getting Started (Clone & Run Locally) | ||
| ## Getting Started (Fork & Add) |
There was a problem hiding this comment.
The Table of Contents at line 11 references "Getting Started (Clone & Run Locally)" but the section title has been changed to "Getting Started (Fork & Add)" at line 19. The Table of Contents anchor link needs to be updated to match the new section title.
|
|
||
| ### 1. Clone the Repository | ||
| ### 1. Fork the Repository | ||
| > **⚠️ IMPORTANT: Make sure you are logged in to your GitHub account. |
There was a problem hiding this comment.
The blockquote is missing a closing double quote. The line should end with a closing quote after "account." to properly close the blockquote text.
| > **⚠️ IMPORTANT: Make sure you are logged in to your GitHub account. | |
| > **⚠️ IMPORTANT: "Make sure you are logged in to your GitHub account."** |
| - Click **"Compare & pull request"** for your branch. | ||
| - Set the base branch to **`gh-pages`**. | ||
| - Add a short description and request a review. | ||
| ### 5. **Open a Pull Request** on GitHub: |
There was a problem hiding this comment.
Step numbering is duplicated: both step 5 (line 45) and step 57 are labeled as "5". Step 57 should be labeled as "7" to follow the correct sequence after step 6.
| ### 5. **Open a Pull Request** on GitHub: | |
| ### 7. **Open a Pull Request** on GitHub: |
| - Set the base branch to **`gh-pages`**. | ||
| - Add a short description and request a review. | ||
|
|
||
| 5. **Once approved and merged**, your changes will be live on the website. |
There was a problem hiding this comment.
Step numbering is inconsistent: line 63 uses "5." for a numbered list item when it should be "8." or should be unnumbered (using a hyphen) to properly follow step 7 above.
| 5. **Once approved and merged**, your changes will be live on the website. | |
| - **Once approved and merged**, your changes will be live on the website. |
| bundle exec jekyll serve | ||
| git add . | ||
| git commit -m "<Brief description of your change>" | ||
| git push |
There was a problem hiding this comment.
The git push command is incomplete and will fail. When pushing a new branch for the first time, you need to specify the remote and set the upstream branch. The command should be "git push origin your-branch-name" or "git push -u origin your-branch-name".
| git push | |
| git push -u origin <your-branch> # e.g. git push -u origin bshah43 |
| ### 6. Merge changes in the main branch of **YOUR FORK** | ||
| - Go to `https://github.com/<Your GitHub username>/logos-lab.github.io`. | ||
| - See the pull requests section. | ||
| - Approve your pull requests and merge with your main branch. |
There was a problem hiding this comment.
Step 6 instructs users to create a pull request in their own fork and merge it there, which is not the typical GitHub fork workflow. Normally, contributors should push their branch to their fork and then create a pull request directly to the upstream repository (Logos-Lab/logos-lab.github.io). The current instructions add unnecessary complexity and an extra merge step that could cause confusion.
Added images/teampics/bhavya.jpg and made changes to _data/students.yaml.