-
Notifications
You must be signed in to change notification settings - Fork 2
Added image and updated description for Bhavya Shah #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,65 +16,49 @@ The website is created using a template from [Allan Lab](https://www.allanlab.or | |||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## Getting Started (Clone & Run Locally) | ||||||
| ## Getting Started (Fork & Add) | ||||||
|
||||||
|
|
||||||
| ### Prerequisites | ||||||
|
|
||||||
| - **Git** — [Install Git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) | ||||||
| - **Ruby** (>= 2.5) and **Bundler** — [Install Ruby](https://www.ruby-lang.org/en/documentation/installation/) | ||||||
| - **Jekyll** — installed automatically via Bundler (see below) | ||||||
|
|
||||||
| ### 1. Clone the Repository | ||||||
| ### 1. Fork the Repository | ||||||
| > **⚠️ IMPORTANT: Make sure you are logged in to your GitHub account. | ||||||
|
||||||
| > **⚠️ IMPORTANT: Make sure you are logged in to your GitHub account. | |
| > **⚠️ IMPORTANT: "Make sure you are logged in to your GitHub account."** |
Copilot
AI
Feb 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git push command is incomplete and will fail. When pushing a new branch for the first time, you need to specify the remote and set the upstream branch. The command should be "git push origin your-branch-name" or "git push -u origin your-branch-name".
| git push | |
| git push -u origin <your-branch> # e.g. git push -u origin bshah43 |
Copilot
AI
Feb 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 6 instructs users to create a pull request in their own fork and merge it there, which is not the typical GitHub fork workflow. Normally, contributors should push their branch to their fork and then create a pull request directly to the upstream repository (Logos-Lab/logos-lab.github.io). The current instructions add unnecessary complexity and an extra merge step that could cause confusion.
Copilot
AI
Feb 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step numbering is duplicated: both step 5 (line 45) and step 57 are labeled as "5". Step 57 should be labeled as "7" to follow the correct sequence after step 6.
| ### 5. **Open a Pull Request** on GitHub: | |
| ### 7. **Open a Pull Request** on GitHub: |
Copilot
AI
Feb 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step numbering is inconsistent: line 63 uses "5." for a numbered list item when it should be "8." or should be unnumbered (using a hyphen) to properly follow step 7 above.
| 5. **Once approved and merged**, your changes will be live on the website. | |
| - **Once approved and merged**, your changes will be live on the website. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,11 +72,14 @@ | |
| number_educ: 0 | ||
| education1: | ||
|
|
||
| - name: Bhavya Shah | ||
| photo: s6.jpg | ||
| - name: Bhavya Minesh Shah | ||
| website: https://search.asu.edu/profile/5016411 | ||
| photo: bhavya.jpg | ||
|
Comment on lines
+75
to
+77
|
||
| info: Master student | ||
| number_educ: 0 | ||
| education1: | ||
| number_educ: 2 | ||
| education1: Master of Science in Robotics and Autonomous Systems (AI) from Arizona State University | ||
| education2: Bachelor of Technology in Computer Science and Engineering from Vellore Institute of Technology, Vellore | ||
| joined: Spring 2026 | ||
|
|
||
| - name: Anudeep Gottapu | ||
| photo: s6.jpg | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Table of Contents at line 12 references "Git Workflow (Branches & Pull Requests)" section but this section no longer exists in the document. The content appears to have been merged into the "Getting Started" section. The Table of Contents should be updated to reflect the current document structure.