Conversation
Contributor
Author
|
@MrAlders0n, please review this focused ambiguity fix (and have Claude review it if useful). It targets current dev and has no server PR dependency. Native Pi build/lint and 874 tests passed for 3a18e6d. The formal review-request API is not available to this contributor account, so I am requesting review here. |
This was referenced Sep 27, 2026
n30nex
force-pushed
the
codex/beacon-endpoint-candidates
branch
from
September 28, 2026 22:38
3a18e6d to
e65e8e4
Compare
Member
|
Nice. It keeps the backend confidence and doesn't pick a winner. One thing before merge:
Minor:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packet endpoint chips discarded all but the first match, which could make an ambiguous TXT_MSG source/destination look conclusive. Show an additional-match count and reuse the existing hop popup to list every candidate on hover, keyboard focus/activation, or touch. Opening a chip no longer also selects its packet row. Logical endpoints also render without physical path metadata.
Closes #74.
Four regressions failed first and now pass. The complete frontend build/lint/874-test suite passes on Windows and native Pi ARM64. No protocol direction change: the current decoder correctly reads destination then source; ambiguity was hidden by presentation. No new dependency or server contract.
AI-assisted implementation and validation under n30nex's standing project authorization. Please review the focused diff; no specific human review of this new diff is being claimed.
Current integration (28 September): the queue is refreshed onto accepted web dev
17f48fb9. Parent17f48fb932facbdcc45068afd2db6036ac2ec94d, published heade65e8e42ec7bcd75029ebc636645eedc2b889cbf. Focused diff. Build/lint/tests pass for this refreshed tree and actual-head build CI passes (repository CodeQL skipped). The full web composition6b688495is now deployed on Pi server2ed2e031, retaining every candidate. Its native build/lint and all 935 tests pass; all 18 public assets and both source archives match. Web assets are byte-identical to the previously geometry-tested build; fresh English desktop/French phone and Public-message packet inspection pass. Current evidence and recovery. Earlier feature-specific validation above is historical. No feature behavior changed in this base refresh.