Repository navigation
Publish twist - #35
Publish twist #35
Conversation
| assert child.status == Status.FAILURE | ||
|
|
||
|
|
||
| def test_timeout() -> None: |
There was a problem hiding this comment.
generally, this test is quite verbose -- I get that it probably uses a lot of fancy bells and whistles from py_trees itself, but it's a little difficult to understand. If there's anything you don't find super critical, I'd encourage simplifying where possible.
There was a problem hiding this comment.
I simplified, but still kept all of the testing, pass-through for success and failure should definitely be checked.
Re-initialization test caught on my first implementation so i think it's valuable.
The pass-through order test is specific to timeout decorator, but i think we get some pretty valuable insight from it.
Does this look better?
scastro-nasa
left a comment
scastro-nasa
left a comment
There was a problem hiding this comment.
Looks great -- thanks for turning around the comments so quickly!
| class TimeoutPort(PortsMixin, Decorator): | ||
| """ | ||
| Reimplementation of the Timeout behavior from the py_trees library | ||
| [Link](https://py-trees.readthedocs.io/en/devel/modules.html#py_trees.decorators.Timeout) for reference. | ||
|
|
||
| NOTE: This behavior is supposed to be temporary. |
There was a problem hiding this comment.
I ended up landing splintered-reality/py_trees#513; I'm gonna work on a PR to update to the latest PyTrees on here and maybe we can remove this sooner than we thought!
There was a problem hiding this comment.
Thank you dealing with that, im still going to take a looks just for my own understanding.
Ill also submit a PR to remove this from the library when it's time.
2 participants
Two new behaviors,