Let building palettes and kit parts carry tiled PBR surfaces - #1749
Merged
Merged
Conversation
A BuildingPalette part (and BuildingKitPart.material) may be a colour plus maps/repeat/roughness/metalness instead of only a hex; generated facade boxes and kit models tile the maps per slot, colour-only consumers read the hex through buildingSurfaceColor. Textures load without suspending and a missing map file (a pack with no ao.jpg) is skipped rather than failing the batch. Pulls ambientCG plaster001 and roofingtiles001 into the dev app for loopline. Refs #1624 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building facades could only be flat colours; the ambientCG Facade/Bricks/Plaster/RoofingTiles packs were already in the catalog but had no seam into the generator. First slice of #1624 (the material path; the mesh path stays blocked on assets).
packages/core/src/world/buildings.ts:BuildingSurfaceMaterial(color,maps,repeat,roughness,metalness),BuildingSurface = string | material,BuildingPaletteparts widen to it;buildingSurfaceColor/resolveBuildingSurfacefor colour-only readers.packages/core/src/world/buildingKit.ts:BuildingKitPart.material.packages/shell/src/structures/buildingSurface.ts: non-suspending map loader with per-caller tiled clones; a missing map file is skipped, not fatal.packages/shell/src/structures/GeneratedBuilding.tsx,BuildingKitBatch.tsx: instanced boxes and kit models apply the surface; kit instances bucket by tint plus surface.CityRenderer.tsx,buildingGenerator.ts: read colours throughbuildingSurfaceColor.apps/dev/public/materials: plaster001 and roofingtiles001 pulled for the loopline shots.Refs #1624. Loopline adoption is in Noisemaker111/JGengine-games (parked until the next SDK release carries these types). vice-isle stays out of scope per the issue note on navigation.
Verification:
check-typescore/shell/editor pass;testbuildings, buildingKit, shell structures pass;check-stateful-ratchet,check-doc-symbols,check-orphan-ratchet,check-changelogpass.loopline
--mode play, before (flat colours) / after (plaster walls, tiled roofs):🤖 Generated with Claude Code