Warn once when a ModelPick fallbackModel is not in the catalog - #1751
Merged
Merged
Conversation
Refs #1346 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pickModelaccepted afallbackModelid that was in no declared pack and shipped a fallback that could never take over (the-robotsred_chest→dungeon/chest).packages/shell/src/render/resolveModel.ts:pickModelnowwarnOnces in dev whenfallbackModelis not in the catalog; resolution behavior unchanged.packages/shell/src/render/resolveModel.test.ts: warns once per id, not for a live fallback.CHANGELOG.md: Unreleased/Fixed bullet.Root cause: the soft-resolve seam had no signal for a dead second tier, so a typo or undeclared pack was silent. Any game using
ModelPickcould hit it; the warning is the upstream reinforcement.Refs #1346
Verification:
bun test packages/shell/src/render/resolveModel.test.tspass (22);bun --cwd=packages/shell run check-typespass. No rendered surface changes, so no screenshots.🤖 Generated with Claude Code