ADR 0002 + phase 1: extract gameContext descriptors, baseline serialization ownership; fix gate baseline drift - #892
Merged
Conversation
… runtime/descriptors (ADR 0002 phase 1) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki
…gate drift) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki
…enerate skill api.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
…text (ADR 0002 phase 3, first cut) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki
… and skills Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki
…e in issues/PRs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Thins the
gameContext.tsgod factory by mechanical, behavior-preserving extraction. The deeper publicsystems/defineSystemauthoring model stays tracked in #842 and builds on this substrate — its "systems own save/replication/reset/disposal" criteria are exactly the descriptor lifecycle contract this PR finishes wiring. Full rationale is in the #842 comment thread; no standalone architecture docs (a new CLAUDE.md rule in this PR forbids them — plans live in issues/PRs, durable knowledge in CLAUDE.md/skills/READMEs).Extraction (behavior-identical,
gameContext.ts2043 → 1404 lines)runtime/descriptors/features.ts—FeatureDeps/FeatureBuild/FeatureDescriptor+ the 13 opt-in descriptors, moved verbatim.runtime/descriptors/baseline.ts— always-onBaselineDescriptorlist owning serialization ofentities/stats/store/feed/inventory(replicate+save) andeconomy/time/pose/possession/motion(save-only).createGameContextcomposessnapshotModules/saveModulesfrom one descriptor pass; module order (snapshot key order) preserved exactly.runtime/context/combatFx.ts— float text, VFX, telegraphs, hit reactions, effect-with-float wrapper.runtime/context/worldItems.ts— ground-item store + spawn/pickup verbs.runtime/context/registries.ts— card-pile / turn-loop / race-state registries.@internal; export manifest regenerated.Parity proof: full suite green (4645 pass / 0 fail, incl.
gameContextSave,worldSnapshot,worldReplication),check-types-all0 errors, build green, orphan-ratchet green.Gate drift fixes (pre-existing red on main, user-authorized)
gen:skill-sizes) — fixes the redcheck-skillson main. Closes Skill-size ratchet red on main — 8 SKILL.md files grew past baseline #891.scripts/api-doc-baseline.json; all.claude/skills/*/api.mdregenerated; capability indexes regenerated.Known remaining (pre-existing, filed as #893):
check-skill-apistill reports ~63 orphan primitives that the orphan gate wants baselined while the shrink-onlycheck-orphan-ratchetforbids adding — needs adopting/@internal-ing those primitives; out of scope here.🤖 Generated with Claude Code
https://claude.ai/code/session_015VP5PE648dXk24vD7x45ki