Repository navigation
Pin the sizes issues 77 and 80 reported in the plate audit - #93
Merged
Merged
Conversation
…later change that lets the page take them with open edges fails the audit The rows are the 2.2 mm magnet over a 2.4 mm shank (refused, built at the widest shank taken), the 6.04 and 6.048 mm heads under the 6 mm magnet, the 10.54 mm head over the 10.28 mm magnet, the 41.24 mm jigsaw with the magnet 2 and 2.2 mm deep and the 7.498, 7.502 and 7.31 mm heads, and the 34.04 mm corner-pocket plate with a 2 mm hole at its 5.8 mm cap and the two sizes past it. The sizes that still leave open edges on corner pockets and at 42 mm are described in the comments, not pinned. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
What this changes
Before. On main after #81, the designs of issues #77 and #80 are closed or refused, but the plate audit had no row for any of them, so a later change could bring their open edges back unseen.
After. The plate audit builds 14 more plates: the 2.2 mm magnet over a 2.4 mm and a 2.3 mm shank at 35.93 mm (refused by the magnet's pocket, built at the widest shank taken), the 6.04 and 6.048 mm heads under the 6 x 2 magnet, the 10.54 mm head over the 10.28 mm magnet on a 2 x 2 plate, the 41.24 mm jigsaw with the magnet 2 and 2.2 mm deep and the 7.498, 7.502 and 7.31 mm heads, and the 34.04 mm corner-pocket plate with a 2 mm hole at its 5.8 mm cap and at the two sizes past it (the second is the issue's link, now refused). Nothing else changes: no engine code, no page.
How. Rows in
test/plate-audit.jsonly, each with a comment saying what it pins and what main did (the 2.4 and 2.3 rows, the 10.54 rows, the jigsaw rows and the 5.81 and 6 mm rows fail on main 326cc48; 6.04 and 6.048 pass there too and pin the bandMOUNT_BORE.head.snap). A re-sweep of both issues on c0dc948 (21,916 corner-pocket designs the page takes, and about 43,000 near-equal magnet, counterbore and shank sizes) found that #81 closed both issues' own cases but that two smaller leaks remain, which the page takes with no warning. They are filed on their own with repro links and are not fixed or pinned here, so this says "Refs" and not "Closes":The report is /mnt/project-files/issue-batches/issue-77-80-report.md. The review's "about six designs worse than main" for #81 do not reproduce.
Refs #77.
Refs #80.
Checks
src/, not the generatedindex.html/bins/index.html:src/is untouched, onlytest/plate-audit.jsnode build.jsand committed the regenerated pages alongside the sources: it rewrites nothingnpm run test:allpasses (run here on 709a07b over c0dc948:npm testexit 0 and the plate UI specs plates-input, plates-robustness, export, keys and half-cells, 186 passed; on 6537ff9, the merge with main 1e1c48a,node test/plate-audit.jsclean, build --check and ci-sim clean; the whole UI suite is left to CI)If this touches geometry
It does not touch geometry.
node test/plate-audit.jsreportsall plates watertight, and no case has picked up bad edges that were not already named as known🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Generated by Claude Code