Skip to content

ci: skip full checks for draft pull requests - #3

Merged
PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-policy
Nov 3, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-policy

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Apply the full-CI policy prepared in project-template #9 to the pnpm template. Ready PRs run on opened, synchronize, reopened and ready_for_review; Draft PR events skip the full check job. Preserve the existing main push trigger, pnpm check command, runtime, check name, concurrency and read-only permissions.

Keep the lightweight Review workflow active for Draft and metadata feedback. Keep both release workflows unchanged, including pr-draft: always. Update CONTRIBUTING, README and the release runbook so maintainers mark release PRs Ready before expecting full CI and distinguish skipped checks from executed tests. No dependency, lockfile, package or publishing behavior changes; no changeset is needed.

Validation

  • pnpm 12.8.1 install --frozen-lockfile passed with isolated caches; the lockfile is unchanged. Node 24.18.0 matches the declared runtime.
  • pnpm run check passed: format, build, lint, typecheck and 15 tests (3 example package tests and 12 repository-script tests).
  • actionlint 1.7.12, gh repo-checks repository and git diff --check passed.
  • A 32-case static matrix parses the actual YAML and evaluates the job guard across Ready/Draft, user/bot, PR/main-push and excluded events; it also verifies lightweight Review behavior. This is static policy validation, not GitHub event-delivery proof.
  • Structural comparison confirms the only executable change is the CI job guard. Review, Version Packages, Publish npm, package manifests and lockfile remain unchanged.
  • On final head 147405bebc3cc74093f88f0f791a1d8cc7d661be, the initial Draft CI run correctly skipped the check job, while Draft Review actually passed all three jobs. The skipped job is not a test pass.
  • Temporarily marking the same PR Ready started full PR CI, which executed and passed pnpm run check including 15 tests; Ready Review also passed. Checkout logs confirm merge 3aa4d04a00629ac43e631d0251ff1c6827a99c92, combining current main 23a8699e837e506d3ea88944df8e0c196854a01c with the final head.
  • The PR was restored to Draft after validation. The final results-only description was checked locally; its edited-event Review is tracked separately. No release or publishing workflow was invoked.

Risks

GitHub reports skipped jobs as successful, even if required; maintainers must verify that the current Ready head and merge result actually executed the full check job. Read-only inspection found no active rulesets or classic branch protection on this repository; settings are unchanged. Workflow approval can still be required for GITHUB_TOKEN-created PR events. This PR does not publish packages or run the release workflows.

@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 09:02
@PerfectPan
PerfectPan marked this pull request as draft November 3, 2026 09:04
@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 09:17
@PerfectPan
PerfectPan merged commit ee73b38 into main Nov 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant