Say that zed_2i_second is a ZED-M placeholder for a second ZED 2i - #739
Merged
Conversation
Serial 13785037 is a ZED-M. It stands in for a second ZED 2i that is on the way. The name stays; the serial changes when the camera arrives. Ticket: Positronic-Robotics/internal#1297 #refs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7abfc68c0a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Both comments predicted a future state: the second ZED 2i arriving, the serial changing with it, and `exterior_2` holding a placeholder "for now". Each goes stale on the day the camera lands, and nothing brings a reader back to correct it. The durable fact is that serial 13785037 is a ZED-M while the name says ZED 2i. The comment states that and points at the ticket, which is where the replacement is tracked. Ticket: Positronic-Robotics/internal#1297 #refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serial 13785037 is a ZED-M. The SDK reports model ZED-M for it, its calibration file groups with the wrist ZED-M, and the kernel reports USB product id
2b03:f682, the ZED-M id. Our config names itzed_2i_second.This change says so, in two comments in
positronic/cfg/hardware/camera.py: one besidezed_2i_second, that the name and the hardware disagree, and one besidedroid_3cam, thatexterior_2therefore has a ZED-M's optics and notexterior's. It renames nothing, and it adds no check and no warning.The name is intended: the slot takes a second ZED 2i, and the ZED-M stands in until that camera arrives. That plan is the ticket's, not the comment's — a comment that predicted the arrival and the serial change would go stale on the day it happened, with nothing bringing a reader back to correct it. So the comments carry only what holds now and cite the ticket, which is where the replacement is tracked.
A policy trained on two matched exterior views does not get them from
droid_3cam. The second comment tells its consumer so.Verification.
/check-rulesoverorigin/main...HEAD, all 14 rules ofCODE_RULES.md, one isolated agent each: no findings, no waivers. Codex'sstale-docfinding on the first pass is fixed and re-checked clean.Ticket: Positronic-Robotics/internal#1297