Throwaway, do not merge: #127 §3.3 CI-gating check with a deliberate manifest mutation - #130
Closed
quantecon-services wants to merge 2 commits into
Closed
Throwaway, do not merge: #127 §3.3 CI-gating check with a deliberate manifest mutation#130quantecon-services wants to merge 2 commits into
quantecon-services wants to merge 2 commits into
Conversation
…t in lingcod_msy_recovery.csv.yml Declares `F_over_Fmsy: 2` where the bytes hold one null, to confirm on a draft PR that validate-datasets goes red with a ::error annotation while consumed-file-check stays green (the data bytes are untouched). Not for merging: the PR is closed once the checks report and this branch is reset to main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015fLD6aY4tU7QZmwWCw6a2T
…gdp_growth_annual.csv Adds an `extra` column the manifest does not claim, to confirm on a draft PR that validate-datasets goes red with a ::error annotation. Not for merging: the PR is closed once the checks report and this branch is reset to main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015fLD6aY4tU7QZmwWCw6a2T
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. This draft PR exists only to run the check in #127 section 3.3: does
validate-datasetsactually gate a PR, and doesconsumed-file-checkstay green when only a manifest is wrong?What is in it
Mutation (i) —
lectures/lingcod_msy_recovery.csv.ymldeclaresknown_nulls: {F_over_Fmsy: 2}where the committed bytes hold exactly one null. No data bytes change.Expected:
validate-datasetsfails with::error file=lectures/lingcod_msy_recovery.csv.yml::F_over_Fmsy: 1 nulls, manifest says exactly 2;consumed-file-checkpasses (every hash still matches andCATALOG.mdis unchanged, verified locally before pushing).A second commit with mutation (a) (an
extracolumn appended togdp_growth_annual.csv) may follow. Expected:validate-datasetsfails with::error file=lectures/gdp_growth_annual.csv.yml::unexpected column(s) not claimed by any entry: ['extra']andconsumed-file-checkfails on the sha256 mismatch, because it hashes every file with a recorded hash regardless ofconsumers— the "stays green" expectation in VALIDATION: independent review of the 2026-09-07 schema-decisions, rename and manifest-driven validator work #127 holds for (i), not for (a).What happens next
The results are recorded in the #127 verification comment, this PR is closed without merging, and the branch is reset to
main.🤖 Generated with Claude Code
https://claude.ai/code/session_015fLD6aY4tU7QZmwWCw6a2T
Generated by Claude Code