ci: run hosted jobs on ubuntu-22.04 - #84
Merged
Merged
Conversation
## Why GitHub does not assign a hosted runner for Release or Package CI. Release on ubuntu-24.04 and Package CI on ubuntu-latest both sit with runner_id 0 and an empty runner_name. Changeset uses ubuntu-latest, so it shares that stuck label. The change is the runner label only. Publish stays the changesets action with OIDC and provenance. There is no new publish path and no NPM_TOKEN. ## Scope - `.github/workflows/release.yml` job `release` moves from `ubuntu-24.04` to `ubuntu-22.04`. - `.github/workflows/ci.yml` job `package` moves from `ubuntu-latest` to `ubuntu-22.04`. - `.github/workflows/changeset.yml` job `changeset` moves from `ubuntu-latest` to `ubuntu-22.04`. Product code, permissions, and the publish script stay as they are. ## Tradeoffs An earlier Release change used macos-latest to leave the Ubuntu queue. This PR does not repeat that move. The next Ubuntu label is the requested change. ## Blast Radius After merge, these three jobs wait on ubuntu-22.04. Package users notice nothing until a Release job publishes. If ubuntu-22.04 also fails to assign, npm stays at 0.6.0. ## Verification origin/main at 53dfe28 has Release on ubuntu-24.04 and Package CI plus Changeset on ubuntu-latest. The Actions jobs API shows queued Release run 35168563360 with labels ubuntu-24.04, runner_id 0, and an empty runner_name. Cancelled Package CI run 35167927752 has labels ubuntu-latest and the same empty runner. git diff against origin/main is three runs-on lines. A runner start is not proven until a job is assigned after merge. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub does not assign a hosted runner for Release or Package CI. Release on
ubuntu-24.04and Package CI onubuntu-latestboth sit withrunner_id0 and an emptyrunner_name. Changeset usesubuntu-latest, so it shares that stuck label.The change is the runner label only. Publish stays the changesets action with OIDC and provenance. There is no new publish path and no
NPM_TOKEN.Scope
.github/workflows/release.ymljobreleasemoves fromubuntu-24.04toubuntu-22.04..github/workflows/ci.ymljobpackagemoves fromubuntu-latesttoubuntu-22.04..github/workflows/changeset.ymljobchangesetmoves fromubuntu-latesttoubuntu-22.04.Product code, permissions, and the publish script stay as they are.
Tradeoffs
An earlier Release change used
macos-latestto leave the Ubuntu queue. This PR does not repeat that move. The next Ubuntu label is the requested change.Blast Radius
After merge, these three jobs wait on
ubuntu-22.04. Package users notice nothing until a Release job publishes. Ifubuntu-22.04also fails to assign, npm stays at 0.6.0.Verification
origin/mainat53dfe28has Release onubuntu-24.04and Package CI plus Changeset onubuntu-latest.The Actions jobs API shows queued Release run
35168563360with labelsubuntu-24.04,runner_id0, and an emptyrunner_name. Cancelled Package CI run35167927752has labelsubuntu-latestand the same empty runner.git diffagainstorigin/mainis threeruns-onlines. A runner start is not proven until a job is assigned after merge.