Special verilog parameters tb_path and output_path don't work in Riviera-PRO#683
Open
pib88 wants to merge 1 commit intoVUnit:masterfrom
Open
Special verilog parameters tb_path and output_path don't work in Riviera-PRO#683pib88 wants to merge 1 commit intoVUnit:masterfrom
pib88 wants to merge 1 commit intoVUnit:masterfrom
Conversation
Contributor
|
It look good to me, however, I do not have Riviera and cannot confirm the issue or the proposed fix. But I do not see any issue with the code. |
eine
force-pushed
the
fix_special_generics_issue
branch
2 times, most recently
from
f108a2a to
ed48a9e
Compare
Special string parameters like tb_path and output_path should be in quotes when used in verilog
eine
force-pushed
the
fix_special_generics_issue
branch
from
ed48a9e to
402bd1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you use tb_path or output_path in verilog they are specified in command line like this:
-gtb_path=<TB_PATH>That does not work in Riviera because you need to put string in double quotes to have it interpreted correctly:
-gtb_path="<TB_PATH>"Since it's impossible to determine parameter type by its value, solution should be limited to parameters that we know are strings: tb_path and output_path.