Repository navigation
fix: save and validate at final FSDP step boundary - #125
Open
number-eleven11 wants to merge 1 commit into
Open
number-eleven11 wants to merge 1 commit into
number-eleven11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing checkpoint and validation interval predicates once more when
train_loopreachesnum_training_steps. This covers a final optimizer step that lands exactly on an interval boundary.Fixes #124.
Why
Inside the loop, the save and validation checks run before
global_step += 1. On the final iteration of a 100-step run, those checks still see step 99. The counter then becomes 100 andfit()exits before its epoch-end save and validation.The added check runs only when the configured training limit has been reached, so normal intermediate interval handling is unchanged.
Reproduction / verification
num_training_steps: 100,save_interval: 100,val_interval: 100, andignore_until_interval: 0in a working FSDP training setup.0_100/model.safetensors; final interval validation also ran.python3 -m py_compile wall_x/trainer/fsdp_trainer/fsdp_trainer.pypython3 -m pytest tests -q(1 passed, 1 skipped)git diff --checkOnly
wall_x/trainer/fsdp_trainer/fsdp_trainer.pyis changed.