Skip to content

refactor: home chemical-heat gate in aqueous_pipeline - #126

Merged
arnoudja merged 2 commits into
masterfrom
cursor/chemical-heat-aqueous-pipeline-b089
Sep 28, 2026
Merged

arnoudja merged 2 commits into
masterfrom
cursor/chemical-heat-aqueous-pipeline-b089

Conversation

@arnoudja

Copy link
Copy Markdown
Owner

Summary

Post-#125 maintainability slice (suggestions #1 + #2 only): move the shared chemical-heat / spit gate out of scene into aqueous_pipeline, and clean write-dead wash/dissolve heat API surface.

Changes

  • Move apply_chemical_heat + CHEMICAL_SPIT_FRAC into aqueous_pipeline; keep note_chemical_spit in scene.
  • Callers (acid_base, dissolve heat, scene mix/filter dilution) use aqueous_pipeline::apply_chemical_heat — no more upward crate::scene::apply_chemical_heat.
  • wash_paper_solids_into_fluid takes fluid_t: f64 by value; drop unused _current_temperature_c from apply_dissolution_temperature_change.
  • Re-export CHEMICAL_SPIT_FRAC from the crate root (was from scene).
  • take_composition_fraction is pub(crate) so the gate can discard spray mass.

Out of scope

Spit OR helpers, spit test file move, FE cue collapse, Φ_V extract, burner, new features.

Verification

cargo test -p chemlab-core --lib — 271 passed.

Open in Web Open in Cursor 

cursoragent and others added 2 commits September 28, 2026 15:33
Move apply_chemical_heat and CHEMICAL_SPIT_FRAC out of scene so
pipeline, acid_base, and dilution no longer call up into the mutator
hub. Clean write-dead fluid_t mut and unused dissolve-heat T param.

Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
@arnoudja
arnoudja marked this pull request as ready for review September 28, 2026 15:38
@arnoudja
arnoudja merged commit 82198bf into master Sep 28, 2026
12 checks passed
@arnoudja
arnoudja deleted the cursor/chemical-heat-aqueous-pipeline-b089 branch September 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants