Repository navigation
refactor: home chemical-heat gate in aqueous_pipeline - #126
Merged
Merged
Conversation
Move apply_chemical_heat and CHEMICAL_SPIT_FRAC out of scene so pipeline, acid_base, and dilution no longer call up into the mutator hub. Clean write-dead fluid_t mut and unused dissolve-heat T param. Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
arnoudja
marked this pull request as ready for review
September 28, 2026 15:38
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-#125 maintainability slice (suggestions #1 + #2 only): move the shared chemical-heat / spit gate out of
sceneintoaqueous_pipeline, and clean write-dead wash/dissolve heat API surface.Changes
apply_chemical_heat+CHEMICAL_SPIT_FRACintoaqueous_pipeline; keepnote_chemical_spitinscene.acid_base, dissolve heat, scene mix/filter dilution) useaqueous_pipeline::apply_chemical_heat— no more upwardcrate::scene::apply_chemical_heat.wash_paper_solids_into_fluidtakesfluid_t: f64by value; drop unused_current_temperature_cfromapply_dissolution_temperature_change.CHEMICAL_SPIT_FRACfrom the crate root (was fromscene).take_composition_fractionispub(crate)so the gate can discard spray mass.Out of scope
Spit OR helpers, spit test file move, FE cue collapse, Φ_V extract, burner, new features.
Verification
cargo test -p chemlab-core --lib— 271 passed.