Repository navigation
Conversation
The J716c ADT wires the Mesa sensor as on the J714s: sensor-id 0x3356 on spi2 at 0x505108000, 8 MHz, chip select 0, power on NUB GPIO 21 (function-mesa_pwr) and data ready on AP GPIO 138. The device tree did not describe it, so apple_sep fell back to the T6020 controller address, found nothing there and never registered the sensor. Enable nub-gpio0, spi2 and their power states and add the fingerprint node with the J714s timing and SPI mode, naming the J716c calibration and root-key files. Expose AP GPIO 138: while it was reserved, gpiolib would have refused the data-ready interrupt's mapping. Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
85fedb0 to
ff2b720
Compare
|
Thanks for this. The node matches the J714s block (spi2 at 0x505108000, 8 MHz, mode 2, NUB GPIO 21 power, AP GPIO 138 data ready), the reserved-range split opens only pin 138, and the J716c is already admitted to the T6050 SEP profile at the current tip. So this PR only needs the device tree. We are also moving the SEP profile choice to the SoC compatible, after which no T6050 machine needs a board admit. The code looks good to us. What is still missing is the user-visible half of the hardware row. On the J716c, at this PR's head (with #1956/#1957 if you need them):
Please paste the |
|
A short follow-up: the SoC-based SEP profile choice we mentioned is now #2311. With it, the J716c no longer needs its entry in the profile list, and this PR stays device tree only. The J716c row we asked for is unchanged (cold-boot SEP lines, enrol plus match and no-match, three deep sleeps each followed by a first-try match, and the finger still listed and matching after a reboot). |
Adds the Touch ID sensor to the J716c device tree, as 4b9a171 did for the J714s.
The J716c wires the sensor the same way as the J714s: spi2 at 0x505108000, 8 MHz, chip select 0,
power on NUB GPIO 21, data ready on AP GPIO 138. Without a node, apple_sep fell back to the T6020
controller address, found nothing and never registered the sensor.
nub_gpio0,spi2and their power states.fingerprint@0node with the J714s timing and SPI mode, namingapple/mesacal-j716c.binand
apple/msrk-j716c.bin.pinctrl_ap's reserved ranges (only 80 and 138 are open; 112 staysreserved).
Testing
On a J716c (M5 Max, 128 GB), 27.0, with this branch, #1956 and #1957 on
integration/aurora59b02d5, and earlier on the J716c daily tree:
and
/dev/sep-bioreports a sensor present; aurora-sep-ready finishes.aurora-touchid-setup, no bring-up retries. Beforethem, the driver reported the root key missing and retried, as expected.
make CHECK_DTBS=y apple/t6050-j716c.dtb apple/t6050-j714s.dtbwith dtschema 2026.9: no newmessages.
🤖 Generated with Claude Code