Update markitdown to 0.1.7 and enhance tests - #1974
Merged
Merged
Conversation
Bump tool version to 0.1.7 and fix several wrapper bugs: - Fix broken --mime-type/--charset options (referenced undefined $mime_opt/$charset_opt variables); now wired to the correct params - Trim ext_map to only Galaxy datatypes that exist in datatypes_conf.xml (drop odt/ods/odp/rtf/bmp/webp/etc.) - Use detect_errors="aggressive" and add version_command - Use argument= on all params and standard output label Expand tests from 5 to 18 with strict golden-file diffs for all deterministic formats (pdf, docx, pptx, xlsx, html, ipynb, csv, tsv, json, xml, txt, markdown) plus assert_contents for zip output and the previously-broken optional-flag code paths (--extension, --mime-type, --charset). Add --keep-data-uris coverage with a dedicated test fixture.
SaimMomin12
approved these changes
Aug 31, 2026
Co-authored-by: Saim Momin <64724322+SaimMomin12@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump tool version to 0.1.7 and fix several wrapper bugs:
Expand tests from 5 to 18 with strict golden-file diffs for all deterministic formats (pdf, docx, pptx, xlsx, html, ipynb, csv, tsv, json, xml, txt, markdown) plus assert_contents for zip output and the previously-broken optional-flag code paths (--extension, --mime-type, --charset). Add --keep-data-uris coverage with a dedicated test fixture.
FOR CONTRIBUTOR:
There are two labels that allow to ignore specific (false positive) tool linter errors:
skip-version-check: Use it if only a subset of the tools has been updated in a suite.skip-url-check: Use it if github CI sees 403 errors, but the URLs work.