Skip to content

[CTX-1317] chore: integrate reviewed local release gate fixes - #2209

Merged
Xuepoo merged 7 commits into
mainfrom
ctx-1317/chore-gate-integration
Oct 17, 2026
Merged

Xuepoo merged 7 commits into
mainfrom
ctx-1317/chore-gate-integration

Conversation

@Xuepoo

@Xuepoo Xuepoo commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #2208

Priority: P1 | Area: release | Labels: chore,P1,area:packaging | Milestone: 0.0.24 | RFC: existing release gate contracts | Task: CTX-1317

Summary

Local release validation was blocked by intentional WSL paths, an inert ELF fixture, and act runner/cache configuration. Integrate their reviewed fixes in exactly seven files while preserving the original help bytes, runtime behavior, remote GHA caching, toolchain pins, and all Quality steps.

  • Add narrow exemptions for contract paths and the never-executed fixture; preserve the help's original two leading spaces with a byte regression.
  • Map local act to ubuntu-24.04 and use bounded local cache storage for ACT only. Run both explicit Quality shards serially under the existing lock, with regression coverage for dispatch, arguments, locking, and failure propagation.
  • Retain original approved source histories; no dependency or docs-pin changes.

Validation

Exact head: fd674a4; base: 1c68de2.

  • Full just check and separate just test: passed, 7211 nextest tests plus doctests/platform/perf/devtools suites.
  • Native and Windows GNU workspace/all-target checks: passed; Windows cross-compilation is not native Windows runtime evidence.
  • Real just ci-local: both Quality jobs succeeded, 3569 + 3642 tests, all applicable steps intact.
  • Formatting, workflow/shell lint, act dry-run, supply chain, secret and whitespace gates: passed.
  • Independent integration APPROVE: PX-6939, all 43 evidence hashes verified, no findings. Full builds were audited rather than duplicated by the reviewer.
  • Fresh parent/recovered/integrated help regression: 0/101/0. Preserved function output is 10479 bytes; all three CLI routes add the expected newline (10480 bytes).
  • Packaging fixture checks and release-version alignment passed on this head; these do not establish live installation or cross-platform artifact acceptance.

Retry history is retained: initial GPU-probe contention and advisory/network fetch failures were rerun with invocation-only serial test/proxy settings; final complete recipes passed without source skips.

This resolves the source work for #2200, #2201, and #2203 as integrated by CTX-1317. Install-consent CTX-1313, clipboard P0 CTX-1315, and exact-candidate plugin/runtime evidence remain release blockers. No tag or release is included.

Summary by CodeRabbit

  • Chores
    • Updated local quality checks to run across both shards with dedicated, bounded caches.
    • Improved compatibility between local CI runs and the configured runner image.
  • Tests
    • Added regression coverage for local quality-check dispatch, cache setup, and failure handling.
    • Added a check to ensure WSL path-mapping help text remains unchanged.

reviewer added 7 commits October 17, 2026 21:32
Restore the two leading spaces verified by compiling the exact unmodified parent help function. Correct the byte regression assertions and retain narrow WSL scratch-path exemptions.

Task: CTX-1306

Refs #2200
Explain the no-execution fixture using the existing per-hit PTY gate exemption. Preserve Linux cfg, executable tokens, and global gate behavior.

Task: CTX-1311

Refs #2203
Map the current Ubuntu runner, use bounded local disk caching under act while preserving remote GHA caching, and serialize bind-mounted matrix checkouts. Bind the local cache endpoint to loopback and cover dispatch, backend setup, locks, and failure propagation.

Refs #2201
Task: CTX-1317
Refs #2200
Preserve reviewed cumulative WSL history including 0b47de3.
Task: CTX-1317; Refs #2203. Preserve original CTX-1311 source history.
Task: CTX-1317; Refs #2200, #2203, #2201. Integrate exact independently reviewed WSL, inert fixture, and local Quality changes; retain all original source history. Commander approval PX-6885. Full integrated verification and independent review required before publication.
@Xuepoo Xuepoo added this to the 0.0.24 milestone Oct 17, 2026
@Xuepoo Xuepoo added chore Chore / maintenance P1 Priority: high area:packaging labels Oct 17, 2026
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 116e3de7-80d4-4ca1-8947-9026f16e94ba
📥 Commits

Reviewing files that changed from the base of the PR and between 1c68de2 and fd674a4.

📒 Files selected for processing: 7
  • .github/act/Dockerfile
  • .github/workflows/ci.yml
  • crates/bitty-runtime/src/component/wsl.rs
  • crates/bitty-sandbox/src/lib.rs
  • crates/bitty-terminal/src/component.rs
  • justfile
  • scripts/tests/ci-local.test.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The local Quality recipe now runs both act shards with the Ubuntu 24.04 mapping and uses a shard-specific local sccache backend under act. Regression checks cover dispatch, cache setup, failure handling, and lock contention. Source changes add path and fixture annotations and test selected help text bytes.

Changes: Local Quality dispatch and cache

Layer / File(s) Summary
Runner mapping and shard dispatch
.github/act/Dockerfile, justfile
The act mapping changes to ubuntu-24.04. The ci-local recipe invokes Quality shards 1 and 2 with the existing options.
Local cache setup and regression checks
.github/workflows/ci.yml, justfile, scripts/tests/ci-local.test.sh
The workflow configures an act-only, shard-specific sccache directory with a 1 GiB limit. The regression test checks dispatch, arguments, failure propagation, lock contention, and cache settings. The check target includes the test.

Source annotations and help-text checks

Layer / File(s) Summary
Path exemptions and preserved help text
crates/bitty-runtime/src/component/wsl.rs, crates/bitty-sandbox/src/lib.rs, crates/bitty-terminal/src/component.rs
The changes add exemption comments for WSL paths and an inert script fixture. The terminal help string is reformatted with concat!, and a test checks selected help lines byte-for-byte.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Sequence Diagram(s)

sequenceDiagram
  participant Justfile
  participant Act
  participant QualityWorkflow
  participant CacheSetup
  Justfile->>Act: invoke Quality shard 1 with ubuntu-24.04 mapping
  Act->>QualityWorkflow: run Quality job
  QualityWorkflow->>CacheSetup: configure act-only shard cache
  Justfile->>Act: invoke Quality shard 2 with ubuntu-24.04 mapping
Loading
Merge Risk: ⚪ Minimal · up to fd674

The help-text assertion matches the displayed text, and no actionable merge-blocking issue remains after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the integration of reviewed fixes for local release gates, which matches the pull request objectives and changes.
Linked Issues check Passed The direct issue is #2208. The supplied PR evidence covers its coding requirements. It reports seven reviewed files, preserved help bytes, unchanged runtime behavior, retained remote GHA caching and t…
Out of Scope Changes check Passed The supplied PR evidence identifies exactly seven changed files. Each file supports a #2208 objective: act configuration, workflow cache setup, gate exemptions, help-byte regression coverage, shard or…
Docstring Coverage Passed Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. (3 skipped: 3 u…
Full details: Linked Issues check

Explanation

The direct issue is #2208. The supplied PR evidence covers its coding requirements. It reports seven reviewed files, preserved help bytes, unchanged runtime behavior, retained remote GHA caching and toolchain pins, and preserved Quality coverage. It adds the WSL and ELF exemptions, local act runner and bounded cache configuration, serial shard dispatch, and regression tests for dispatch, arguments, locking, and failure propagation. It also reports passing check/test, native and Windows GNU checks, both local Quality jobs, and the stated integration validation. No coding requirement from #2208 remains unmet.

Full details: Out of Scope Changes check

Explanation

The supplied PR evidence identifies exactly seven changed files. Each file supports a #2208 objective: act configuration, workflow cache setup, gate exemptions, help-byte regression coverage, shard orchestration, or local CI regression coverage. The evidence reports no dependency or documentation-pin changes and no release tag. The remaining install-consent and clipboard blockers are explicitly retained as blockers, not changed by this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Xuepoo Xuepoo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review verdict — recorded by guard hermes-planner on behalf of a separate reviewer agent (CTX-1317). Verdict authored before this PR: PX-6939.

Verdict: APPROVE — severity none. Exact head fd674a4c598be2e12020ef28c7da34859e0fd1c1, base 1c68de2545c961790d0a2011340e4a3c04564ab7.

CarryCtx evidence (verbatim excerpts):

  • PX-6939 (independent integration review): "APPROVE independent integration review, severity none, exact head fd674a4 vs base 1c68de2. Seven files 201+/15- exactly match approved source diffs/blobs; original ancestors retained including 0b47de3. No extra pins/source/gate skips. Independent light/dispatch/shell/diff/redacted-secret gates PASS. Fresh extracted help/regression 10479 bytes SHA0a3cf25e... and 0/101/0; all three saved CLI routes 10480 exact. All 43 manifest hashes verified. Raw full check/test/native/Windows/actualQuality bothJobs 3569+3642 evidence reviewed, not rebuilt; retries transparent and invocation-only. Clean exact head, task cache and standalone executables absent."
  • PX-6942 (commander read-back): "Commander verified independent integration APPROVE PX-6939, exact clean fd674a4 and unchanged current main 1c68de2."
  • checkpoint 01M559XS: "[Independent] CTX-1317 [integration] review [APPROVE] at fd674a4, severity none".

Head note: head fd674a4c is a descendant of current origin/main 1c68de25 — branch is up to date with main; no rebase needed.

CI on the exact head fd674a4c: all required checks green — Quality gates (1)(2), Linux Wayland, Linux X11 (xvfb), macOS ARM64 check and test, Windows check and test, MSRV 1.85 check, Supply chain (deny/audit), CodeQL, Analyze (actions)/(rust), M1/Compat aggregates, VM tier (PR).

Scope note: this merge closes Issue #2208 only; it is not a whole-release acceptance. P0 install-consent (CTX-1313), clipboard (CTX-1315) and plugin-runtime evidence remain release blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:packaging chore Chore / maintenance P1 Priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[release] Integrate reviewed local release gate fixes

1 participant