Repository navigation
[CTX-1317] chore: integrate reviewed local release gate fixes - #2209
Conversation
Restore the two leading spaces verified by compiling the exact unmodified parent help function. Correct the byte regression assertions and retain narrow WSL scratch-path exemptions. Task: CTX-1306 Refs #2200
Explain the no-execution fixture using the existing per-hit PTY gate exemption. Preserve Linux cfg, executable tokens, and global gate behavior. Task: CTX-1311 Refs #2203
Map the current Ubuntu runner, use bounded local disk caching under act while preserving remote GHA caching, and serialize bind-mounted matrix checkouts. Bind the local cache endpoint to loopback and cover dispatch, backend setup, locks, and failure propagation. Refs #2201
Task: CTX-1317; Refs #2203. Preserve original CTX-1311 source history.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Xuepoo
left a comment
There was a problem hiding this comment.
Independent review verdict — recorded by guard hermes-planner on behalf of a separate reviewer agent (CTX-1317). Verdict authored before this PR: PX-6939.
Verdict: APPROVE — severity none. Exact head fd674a4c598be2e12020ef28c7da34859e0fd1c1, base 1c68de2545c961790d0a2011340e4a3c04564ab7.
CarryCtx evidence (verbatim excerpts):
PX-6939(independent integration review): "APPROVE independent integration review, severity none, exact head fd674a4 vs base 1c68de2. Seven files 201+/15- exactly match approved source diffs/blobs; original ancestors retained including 0b47de3. No extra pins/source/gate skips. Independent light/dispatch/shell/diff/redacted-secret gates PASS. Fresh extracted help/regression 10479 bytes SHA0a3cf25e... and 0/101/0; all three saved CLI routes 10480 exact. All 43 manifest hashes verified. Raw full check/test/native/Windows/actualQuality bothJobs 3569+3642 evidence reviewed, not rebuilt; retries transparent and invocation-only. Clean exact head, task cache and standalone executables absent."PX-6942(commander read-back): "Commander verified independent integration APPROVE PX-6939, exact clean fd674a4 and unchanged current main 1c68de2."- checkpoint
01M559XS: "[Independent] CTX-1317 [integration] review [APPROVE] at fd674a4, severity none".
Head note: head fd674a4c is a descendant of current origin/main 1c68de25 — branch is up to date with main; no rebase needed.
CI on the exact head fd674a4c: all required checks green — Quality gates (1)(2), Linux Wayland, Linux X11 (xvfb), macOS ARM64 check and test, Windows check and test, MSRV 1.85 check, Supply chain (deny/audit), CodeQL, Analyze (actions)/(rust), M1/Compat aggregates, VM tier (PR).
Scope note: this merge closes Issue #2208 only; it is not a whole-release acceptance. P0 install-consent (CTX-1313), clipboard (CTX-1315) and plugin-runtime evidence remain release blockers.
Closes #2208
Priority: P1 | Area: release | Labels: chore,P1,area:packaging | Milestone: 0.0.24 | RFC: existing release gate contracts | Task: CTX-1317
Summary
Local release validation was blocked by intentional WSL paths, an inert ELF fixture, and act runner/cache configuration. Integrate their reviewed fixes in exactly seven files while preserving the original help bytes, runtime behavior, remote GHA caching, toolchain pins, and all Quality steps.
Validation
Exact head: fd674a4; base: 1c68de2.
Retry history is retained: initial GPU-probe contention and advisory/network fetch failures were rerun with invocation-only serial test/proxy settings; final complete recipes passed without source skips.
This resolves the source work for #2200, #2201, and #2203 as integrated by CTX-1317. Install-consent CTX-1313, clipboard P0 CTX-1315, and exact-candidate plugin/runtime evidence remain release blockers. No tag or release is included.
Summary by CodeRabbit