Skip to content

refactor(replay): move source and target decisions into replay-port (#2663) - #3007

Merged
thymikee merged 2 commits into
mainfrom
codex/2663-replay-port-move
Sep 28, 2026
Merged

thymikee merged 2 commits into
mainfrom
codex/2663-replay-port-move

Conversation

@thymikee

@thymikee thymikee commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Moves three self-contained replay port decisions into @agent-device/replay-port: bundled script source lookup, target token extraction, and repair hint classification. Their tests move with them. Daemon callers use package subpaths; behavior and wire responses are unchanged. This is the next staged move toward #2663's PR B after #2769 bootstrapped the package.

19 files touched, including six source/test moves and a corrected owner-path reference. The replay tree still has 102 files; its daemon-backed integration harnesses need separate fixture extraction before the remaining move.

Validation

Tested commit 7d75e20d4545233d4f93d08c04f291afa7f4db93.

  • pnpm check:affected --run: all runnable checks passed, including 224 related test files / 1,275 tests, layering, typecheck, lint, build, package, fallow, and export checks. Package manifest and lockfile changes selected the full local gate set.
  • The three moved test files pass in their package location: 30 tests.
  • git diff --check origin/main...HEAD: clean. CI pending.

No live device replay was run for this location-only move. The remaining native, Maestro, and replay-test adapter move still needs the issue's live .ad and Maestro characterization.

Part of #2663.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-28 11:13 UTC

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.87 MB 4.87 MB 0 B
Package (unpacked) 4.87 MB 4.87 MB 0 B
Package (download) 1.46 MB 1.46 MB +1 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 21.3 ms 21.1 ms -0.2 ms
CLI --help 61.9 ms 59.3 ms -2.6 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 18 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/replay-port/src/daemon-port/repair-hint.ts">

<violation number="1" location="packages/replay-port/src/daemon-port/repair-hint.ts:2">
P3: After this rename, `packages/contracts/src/replay-divergence.ts:184` still points to the old module path `src/daemon/replay/internal/session-replay-repair-hint.ts`, which no longer exists anywhere in the tree. Update that doc reference to `packages/replay-port/src/daemon-port/repair-hint.ts` (or drop the path) to keep the ADR cross-reference accurate.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@@ -1,5 +1,5 @@
/**
* ADR 0012 decision 6, R3: the daemon-side `repairHint` computation.
* ADR 0012 decision 6, R3: the replay port's `repairHint` computation.

@cubic-dev-ai cubic-dev-ai Bot Sep 28, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: After this rename, packages/contracts/src/replay-divergence.ts:184 still points to the old module path src/daemon/replay/internal/session-replay-repair-hint.ts, which no longer exists anywhere in the tree. Update that doc reference to packages/replay-port/src/daemon-port/repair-hint.ts (or drop the path) to keep the ADR cross-reference accurate.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/replay-port/src/daemon-port/repair-hint.ts, line 2:

<comment>After this rename, `packages/contracts/src/replay-divergence.ts:184` still points to the old module path `src/daemon/replay/internal/session-replay-repair-hint.ts`, which no longer exists anywhere in the tree. Update that doc reference to `packages/replay-port/src/daemon-port/repair-hint.ts` (or drop the path) to keep the ADR cross-reference accurate.</comment>

<file context>
@@ -1,5 +1,5 @@
 /**
- * ADR 0012 decision 6, R3: the daemon-side `repairHint` computation.
+ * ADR 0012 decision 6, R3: the replay port's `repairHint` computation.
  *
  * Computed daemon-side at divergence time, never by the agent, from (i) the
</file context>
Fix with cubic

@thymikee
thymikee force-pushed the codex/2663-replay-port-move branch from 06f722b to 7d75e20 Compare September 28, 2026 10:35
@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at 06f722b. This is a clean move of the source and target decisions into replay-port, with only import rewiring and the package dependency. The newer head 7d75e20 differs from it only by the ReplayRepairHint JSDoc path fix, which was the one note I had.

CI: Smoke Tests was still running. This change does not alter any CLI or daemon route.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 28, 2026
@thymikee
thymikee merged commit 36e0cff into main Sep 28, 2026
21 checks passed
@thymikee
thymikee deleted the codex/2663-replay-port-move branch September 28, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant