refactor(replay): move source and target decisions into replay-port (#2663) - #3007
Conversation
|
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
1 issue found across 18 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/replay-port/src/daemon-port/repair-hint.ts">
<violation number="1" location="packages/replay-port/src/daemon-port/repair-hint.ts:2">
P3: After this rename, `packages/contracts/src/replay-divergence.ts:184` still points to the old module path `src/daemon/replay/internal/session-replay-repair-hint.ts`, which no longer exists anywhere in the tree. Update that doc reference to `packages/replay-port/src/daemon-port/repair-hint.ts` (or drop the path) to keep the ADR cross-reference accurate.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * ADR 0012 decision 6, R3: the daemon-side `repairHint` computation. | |||
| * ADR 0012 decision 6, R3: the replay port's `repairHint` computation. | |||
There was a problem hiding this comment.
P3: After this rename, packages/contracts/src/replay-divergence.ts:184 still points to the old module path src/daemon/replay/internal/session-replay-repair-hint.ts, which no longer exists anywhere in the tree. Update that doc reference to packages/replay-port/src/daemon-port/repair-hint.ts (or drop the path) to keep the ADR cross-reference accurate.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/replay-port/src/daemon-port/repair-hint.ts, line 2:
<comment>After this rename, `packages/contracts/src/replay-divergence.ts:184` still points to the old module path `src/daemon/replay/internal/session-replay-repair-hint.ts`, which no longer exists anywhere in the tree. Update that doc reference to `packages/replay-port/src/daemon-port/repair-hint.ts` (or drop the path) to keep the ADR cross-reference accurate.</comment>
<file context>
@@ -1,5 +1,5 @@
/**
- * ADR 0012 decision 6, R3: the daemon-side `repairHint` computation.
+ * ADR 0012 decision 6, R3: the replay port's `repairHint` computation.
*
* Computed daemon-side at divergence time, never by the agent, from (i) the
</file context>
06f722b to
7d75e20
Compare
|
Reviewed at 06f722b. This is a clean move of the source and target decisions into replay-port, with only import rewiring and the package dependency. The newer head 7d75e20 differs from it only by the CI: Smoke Tests was still running. This change does not alter any CLI or daemon route. |
Summary
Moves three self-contained replay port decisions into
@agent-device/replay-port: bundled script source lookup, target token extraction, and repair hint classification. Their tests move with them. Daemon callers use package subpaths; behavior and wire responses are unchanged. This is the next staged move toward #2663's PR B after #2769 bootstrapped the package.19 files touched, including six source/test moves and a corrected owner-path reference. The replay tree still has 102 files; its daemon-backed integration harnesses need separate fixture extraction before the remaining move.
Validation
Tested commit
7d75e20d4545233d4f93d08c04f291afa7f4db93.pnpm check:affected --run: all runnable checks passed, including 224 related test files / 1,275 tests, layering, typecheck, lint, build, package, fallow, and export checks. Package manifest and lockfile changes selected the full local gate set.git diff --check origin/main...HEAD: clean. CI pending.No live device replay was run for this location-only move. The remaining native, Maestro, and replay-test adapter move still needs the issue's live
.adand Maestro characterization.Part of #2663.