Skip to content

refactor(move): relocate replay repair and suite integration tests - #3032

Merged
thymikee merged 2 commits into
codex/2663-replay-resume-failurefrom
codex/2663-replay-repair-tests
Sep 28, 2026
Merged

thymikee merged 2 commits into
codex/2663-replay-resume-failurefrom
codex/2663-replay-repair-tests

Conversation

@thymikee

@thymikee thymikee commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Move 21 daemon-backed replay repair and test-suite files into src/daemon/__tests__/replay-repair and replay-suite. Relative module specifiers now resolve from those daemon test locations; test behavior is unchanged.
  • Move the existing path-keyed fallow health baseline entry for the renamed suite runner test. The replay subtree now has 54 files, including 16 production modules.

Part of #2663. This stack layer depends on #3030 and keeps daemon integration tests outside the eventual replay-port package.

Validation

  • Exact head cb12993ef40d6dcc3060372589d15d367f844193: pnpm check:affected --run passed (613 related files, 5,419 tests; provider integration and wire compatibility passed).
  • All 98 moved tests passed directly; pnpm check:quick, pnpm check:layering, and pnpm check:fallow --base origin/main passed.
  • GitHub Coverage and Integration Tests remain CI-owned. Live .ad and Maestro characterization will run on the completed package migration commit.

@thymikee
thymikee added this pull request to stack #3020 September 28, 2026 12:30
@thymikee thymikee changed the title codex/2663 replay repair tests refactor(move): relocate replay repair and suite integration tests Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.87 MB 4.87 MB 0 B
Package (unpacked) 4.87 MB 4.87 MB 0 B
Package (download) 1.46 MB 1.46 MB +5 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 28.1 ms 28.5 ms +0.4 ms
CLI --help 83.1 ms 83.7 ms +0.7 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 22 files

Re-trigger cubic

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at cb12993. This is a clean move: all 21 test and fixture files are renames with only import-path edits, no test is lost, and no production code changes.

Question, not blocking: src/daemon/__tests__/replay-suite/session-test-source-discovery.test.ts only tests buildReplayTestSourceDiscovery from src/daemon/replay/internal/session-test-source-discovery.ts and uses no daemon handler or session store. Should it stay next to its source, so it moves with it into packages/replay-port in the next step of #2663?

The failing Smoke Tests job is a live iOS simulator wait timeout ("wait for Automation lab"). This diff does not touch that path, so it looks unrelated.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 28, 2026
@thymikee
thymikee force-pushed the codex/2663-replay-repair-tests branch from cb12993 to 319f190 Compare September 28, 2026 16:35
@thymikee
thymikee merged commit 192ac0b into main Sep 28, 2026
25 of 36 checks passed
@thymikee
thymikee deleted the codex/2663-replay-repair-tests branch September 28, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant