refactor: Rules class helper methods as free functions - #195
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
MichaelThamm
commented
Jun 25, 2026
Signed-off-by: Michael Thamm <mike.thamm@canonical.com>
MichaelThamm
commented
Jun 25, 2026
MichaelThamm
marked this pull request as ready for review
June 26, 2026 14:57
lucabello
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We have some static methods in
Rulesthat we want to move to free functions so that they can be reused in other rules-like classes e.g., SigmaRules.Solution
Checklist
project.versionfield in thepyproject.tomlfile.Context
These static methods were private so we have relative confidence that they were not used externally.
Ref to other PRs for context:
Testing Instructions
Use these free functions in the Rules class which is thoroughly tested by the existing unit tests in cosl.
Upgrade Notes