Repository navigation
Accept both native Fabric client URI service names - #4429
Merged
Merged
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
schickling-assistant
marked this pull request as ready for review
October 31, 2026 03:26
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:26 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:26 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:26 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:26 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:31 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:31 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:32 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:32 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
October 31, 2026 03:49 — with
GitHub Actions
Inactive
Contributor
Author
|
Merge record (Fabric-mesh, fractal merge rule Q26+Q31):
Posted on behalf of @schickling
|
This was referenced Oct 31, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rust and Node native Fabric clients only accept
fabric://<node-or-name>/st3-client-v0, so afractal-client-v0URI is rejected before dialing.Change
st3-client-v0service. URI formatters, gateway defaults and gateway exposure remain unchanged.$alone accepts a final newline).Verification
Exact head:
aa026353b49b17e29a7a881736188797065f7c15. Both targeted suites ran undergate-slot --lane build --max-wait 5400 -- nix develop -c …:cargo test -p fractal-client fabric::tests --lib: 8 passed, 0 failed.node --test clients/typescript/fractal-client/fabric.test.cjs: 5 passed, 0 failed, using the pinned TypeScript-client installation throughNODE_PATH.Coverage includes old/new URI spellings, wrong services, exact URI anchoring/trailing line breaks, canonical old formatting, identical gateway dial arguments for peer names and NodeIDs, trusted-name ambiguity/refusal, routing guards, authenticated HTTP and client WebSocket streams.
Before:
fractal-client-v0URI rejected. After: it parses and dialsst3-client-v0; existing old URIs still work.Build target removed after testing: 321,206,272 allocated bytes reclaimed (856,150,512 apparent bytes). No live gateway or host changes. No broad suite or formatter was run.
Admission friction: the first Rust request expired while queued, before running; the deadline-free retry passed. Shared build admission and a GC fence dominated wait time.
Open questions
None. This is an accepting-reader change only; switching URI writers/defaults belongs to the later writer slice. The new URI spelling intentionally maps to the currently exposed old gateway service instead of changing exposure.
Refs #4424 (fleet accepting-reader companion).
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree