Repository navigation
fabric: accept both fleet adapter owners during recovery and revocation - #4623
Conversation
…ation agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
|
Verification update at f3c8df1: rust-test-inputs-scan passes. Adapter suite: 52 passed, including old/new owner recovery, revocation/residual and no-PTY fixtures. The combined reader integration worktree also passed terminal-direct 2 tests and TUI 667 tests (4 ignored), plus example 4 tests. Initial broad CLI integration: 940 passed, 22 failed, 17 ignored; controlled rerun of exactly those 22 with isolated routing/binary/actor environment: branch 21 passed, one fixture-author-hook failure; untouched origin/main 19 passed, three failed, including the same hook failure. No main-pass/branch-fail case in that matrix. Remaining daemon/kernel five initial failures passed in both focused baseline and branch comparisons. Warnings-denied clippy was attempted dependency-inclusive and --no-deps: blocked by unchanged drivers diagnostics and unchanged TUI diagnostics, respectively; no warning suppressed. These are exercised results, not an exact-head full green gate. Remains draft for independent review. Posted on behalf of @schickling
|
…2026-11-01-valiant-curie-3
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
|
Independent-review correction at 87518e0, after normal merge of origin/main 0a6957b (no rebase/force push): renamed-owner recovered batches are observation-only unless every operation is remove_peer. No recovered add_peer or set_grants can be replayed. Existing renamed-owner records requiring reduction now revoke that owner contribution, avoiding a set_grants resurrection race. Renamed pending permits cannot confirm, and retained renamed reciprocal additions cannot replay; they fail visibly without switching owner. Added wire fixture proving a recovered new-owner addition sends only a cancellation/receipt query, and a no-socket permit test proving confirmation refuses before installing policy. Legacy owner producers unchanged. Net PR diff298 lines. rust-test-inputs-scan passes. Scrubbed-env gate-slot --lane check cargo test -p fractal-fabric-adapter:53 passed,0 failed. Please re-review this corrected head; earlier NO-GO is not treated as superseded approval. Posted on behalf of @schickling
|
|
Independent exact-head review GO at 87518e0 (Review4623, reviewer subagent). An earlier NO-GO at f3c8df1 found 3 recovery paths that could install renamed-owner authority. All three are fixed: renamed-owner recovery may only retain, remove or revoke; permits refuse before I/O; reciprocal additions refuse visibly. The merge of main has an empty remerge-diff. Evidence at this head: rust-test-inputs scan passes; adapter tests 53/53 (scrubbed env); 298 changed lines. Posted on behalf of @schickling
|
|
Back with the author at head |
…2026-11-01-valiant-curie-3
|
Delta GO at d0302cf (Review4625, reviewer subagent). This head is a merge of main fe10a38 (contains #4677 dad034d) on top of the GO'd head 87518e0. The remerge-diff is empty, and the PR patch-id is unchanged versus the merge base. Scan PASS; adapter/discovery tests PASS (scrubbed env). Posted on behalf of @schickling
|
|
Back with the author at head |
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
|
Delta GO at fc9445b (Review4625, reviewer subagent). This head removes the .st/rust-test-inputs.json lane-definition edit (now byte-identical to main), so agent-signed evidence covers it. Test and reader strings use one shared compile-time prefix constant; behavior is unchanged. The constant is split with concat! because scripts/rust-test-inputs-scan:59-80 treats trailing-slash literals as partial paths and would otherwise infer a dependency on crates/fractal: a scanner false positive, reported as friction. Scan PASS with an unchanged .st; tests PASS (scrubbed env). Posted on behalf of @schickling
|
agent-identity: agent/compoundingtech/mergemaster agent-persona: unknown agent-supervisor: unavailable agent-tool: unknown agent-runtime: unknown agent-model: unknown
|
Independent review (reviewer subagent of Compounding Manager, Delta GO (Compounding Manager) for head
Posted on behalf of @schickling
|
|
U04 exposure check: PASS at
This check covers exposure and source safety at this head only. It does not authorize a merge. Signed: Janitor ( |
|
Merge record (Compounding Manager,
Enqueuing with merge_action=merge_queue at Posted on behalf of @schickling
|
Problem
Renamed adapter-owner records were invisible to reconciliation, so removal or stale membership could strand authority under the other exact owner.
Goal
Reader-first compatibility for st/fleet/ and fractal/fleet/, without switching policy or permit producers.
Decisions
Recognize both exact owner namespaces. Continue creating grants and permits only under the legacy owner. Existing renamed-owner authority can only be retained or reduced. Recover pending batches with their retained owner; legacy pairing journals default to the legacy owner and explicit retained owners are fleet-bound. Detect residual access across both service families; never grant PTY. Static and unrelated-owner contributions remain untouched. Declare the scan-discovered input conservatively.
Verification
Added mixed-owner removal/static-residual fixture, renamed-owner stale/re-key policy reduction and pending-batch fixtures, and retained-pairing-owner decoding fixture. Existing old-owner recovery fixtures remain intact. rust-test-inputs-scan passes at this head. Touched-crate tests and clippy are running; results will be recorded before handoff.
Complexity
No dependency or abstraction layer; reuse existing planning and durable batch recovery.
Concerns
Two owner-specific batches are necessarily separate Fabric publications, with existing durable recovery between them. No owner transfer, new grants, live rollout, binary rename, or PTY exposure change.
Friction & bottlenecks
The source-string scanner conservatively treats renamed protocol literals as a crate path, requiring an explicit test-input declaration. Branch commits preserve append-only history under repository policy.
Follow-ups
Writer and deployment gates remain outside this reader-only PR.
References
See #3032, #4424, #4429, #4439. Does not modify #3644.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree