Skip to content

refactor(ci): replace recheck-open-prs with the merge queue - #707

Merged
devantler merged 2 commits into
mainfrom
claude/remove-recheck-open-prs-704
Nov 14, 2026
Merged

devantler merged 2 commits into
mainfrom
claude/remove-recheck-open-prs-704

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

recheck-open-prs (~2k lines with tests) re-ran every open PR whenever main moved, so a PR opened before a new gate still had to meet it. A merge queue does this natively and more strongly: it runs CI - Required Checks on the exact result each PR would land as.

What

  • Delete recheck-open-prs.yaml, scripts/recheck-open-prs.sh, its three tests and docs/pr-recheck-recovery.md, plus their CI steps and the sharding-test entries.
  • Remove the proposal workflow's recheck job, which only dispatched the deleted workflow. A dispatched proposal draft is created with the workflow token, so it now gets its PR CI when a maintainer closes and reopens it. Automatic proposals are off (MARKETPLACE_AUTOPROPOSE is unset), and Keep one plugin manifest set and release with release-please #705 replaces this proposal path.
  • Docs describe the merge queue instead.

Order (keep as draft until 1 and 2 are live)

  1. ci: run the required checks on merge groups #706: CI runs on merge_group.
  2. feat(rulesets): require a merge queue on agent-plugins .github#932: the merge-queue ruleset.
  3. This PR, merged through the queue.

Validation

validate-manifests.sh, check-skill-authoring.sh, ci-script-test-sharding-workflow.test.sh, marketplace-proposal-workflow.test.sh and shellcheck scripts/*.sh pass locally. actionlint reports only an existing concurrency.queue finding in update-agent-skills.yaml, which this PR does not touch.

Closes #704

🤖 Generated with Claude Code

The merge queue now runs the required checks on the exact result each
PR would land as, which is what recheck-open-prs approximated by
re-running every open PR after main moved. Removes the workflow, its
script, three tests, the recovery guide and the proposal workflow's
dispatch of it.

Closes #704

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b060a0ad-04bc-4a17-8f96-a32c9f624570
Commits

Reviewing files that changed from the base of the PR and between e7ba7bf and 5363a3f.

Files selected for processing: 15

  • .github/workflows/ci.yaml
  • .github/workflows/propose-marketplace-release.yaml
  • .github/workflows/recheck-open-prs.yaml
  • README.md
  • docs/marketplace-releases.md
  • docs/pr-recheck-recovery.md
  • docs/scripts.md
  • docs/tool-ownership.md
  • docs/validation.md
  • scripts/ci-script-test-sharding-workflow.test.sh
  • scripts/marketplace-proposal-workflow.test.sh
  • scripts/recheck-open-prs-base-refresh.test.sh
  • scripts/recheck-open-prs-observations.test.sh
  • scripts/recheck-open-prs.sh
  • scripts/recheck-open-prs.test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@botantler-1 botantler-1 Bot closed this Nov 14, 2026
@botantler-1 botantler-1 Bot reopened this Nov 14, 2026
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 14, 2026
@github-project-automation github-project-automation Bot moved this from ✅ Done to 🫴 Ready in 🌊 Project Board Nov 14, 2026

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: 3bc88ca

  • CodeRabbit: review limit reached on agent-plugins at 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
  • Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
  • Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)

Verdict: no P0/P1 findings

🤖 Generated with Claude Code

@devantler
devantler marked this pull request as ready for review November 14, 2026 20:17
@devantler
devantler added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 84adef2 Nov 14, 2026
34 of 40 checks passed
@devantler
devantler deleted the claude/remove-recheck-open-prs-704 branch November 14, 2026 20:40
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Replace recheck-open-prs with a merge queue

1 participant