Repository navigation
feat(portal): let clients order the standard add-ons - #623
Conversation
@codex review for standard add-ons: catalogue validation, GET-based selection and totals before the order button, stored add-ons and totals, one Numina and Stripe line per add-on, discount on the base price only |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bc39ef584
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review on #623: - An impossible add-on choice (both priority tiers, or units out of range) stays ticked with its reason, and the receipt offers no order until the client corrects it, instead of silently ordering without add-ons. - A retry of an existing order compares the add-ons it names with the order's stored ids and units, keeping their stored prices, so a later catalogue change does not turn a card restart into a conflict. Only a new order is checked against the current catalogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7bc39ef to
8453916
Compare
@codex review for Re-review after the findings on the previous head were fixed (see the replies on each thread). |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3b46f0c to
dd0f46a
Compare
Codex review on #623: - An impossible add-on choice (both priority tiers, or units out of range) stays ticked with its reason, and the receipt offers no order until the client corrects it, instead of silently ordering without add-ons. - A retry of an existing order compares the add-ons it names with the order's stored ids and units, keeping their stored prices, so a later catalogue change does not turn a card restart into a conflict. Only a new order is checked against the current catalogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8453916 to
17a1650
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5edcbec6e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd0f46a to
a592c55
Compare
Codex review on #623: - An impossible add-on choice (both priority tiers, or units out of range) stays ticked with its reason, and the receipt offers no order until the client corrects it, instead of silently ordering without add-ons. - A retry of an existing order compares the add-ons it names with the order's stored ids and units, keeping their stored prices, so a later catalogue change does not turn a card restart into a conflict. Only a new order is checked against the current catalogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5edcbec to
61fe284
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61fe2842fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a592c55 to
e357d88
Compare
Codex review on #623: - An impossible add-on choice (both priority tiers, or units out of range) stays ticked with its reason, and the receipt offers no order until the client corrects it, instead of silently ordering without add-ons. - A retry of an existing order compares the add-ons it names with the order's stored ids and units, keeping their stored prices, so a later catalogue change does not turn a card restart into a conflict. Only a new order is checked against the current catalogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Hint Codex review on #623: a catalogue price change deployed between the order summary and the order button would have charged the new price. Each add-on's form value now carries the unit price the client was shown, and a new order is refused unless the catalogue still has it. A retry keeps the stored prices. CI's template check (HTMLHint) refused template actions inside tags: the add-on checkboxes and the units select now render whole tags in if/else and use wrapping labels instead of template ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
61fe284 to
3a06b48
Compare
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The maintainer approved a standard set of add-ons (offerings.json addons): monthly feature-request priority tiers, visitor statistics and email sending, and one-time extras such as an extra language, a contact form or online payments. - The receipt lists the add-ons that fit the request's offering (monthly ones only with hosting); the client ticks them and the summary before the order button shows each line and the total. - The order stores them with their unit prices (portal_order_addons, migration v25); its prices include them, so funding, withdrawals and settlements work unchanged. At most one priority tier per order. - The launch discount takes off the proposal's own one-time price only. - Numina invoices and Stripe Checkout get one line per add-on: one-time ones with the first charge, monthly ones every month. - The confirmation email, the receipt and the operator's page list them. - business-site AGENTS.md: requests outside the offer become addon-candidate issues that describe only the request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex review on #623: - An impossible add-on choice (both priority tiers, or units out of range) stays ticked with its reason, and the receipt offers no order until the client corrects it, instead of silently ordering without add-ons. - A retry of an existing order compares the add-ons it names with the order's stored ids and units, keeping their stored prices, so a later catalogue change does not turn a card restart into a conflict. Only a new order is checked against the current catalogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The maintainer's decision on the terms review (#621): Priority and Express are targets, not guarantees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Hint Codex review on #623: a catalogue price change deployed between the order summary and the order button would have charged the new price. Each add-on's form value now carries the unit price the client was shown, and a new order is refused unless the catalogue still has it. A retry keeps the stored prices. CI's template check (HTMLHint) refused template actions inside tags: the add-on checkboxes and the units select now render whole tags in if/else and use wrapping labels instead of template ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3a06b48 to
3164548
Compare
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Code coverage overviewLanguages: Go Go / code-coverage/go
Line coverage data for the main branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
MegaLinter's djlint (H015) wants a line break after a heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codex review for One-line markup change after the last green: a line break after the add-on heading (djlint H015). |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
@codex review for Only MegaLinter's automatic Prettier reformatting of offerings.json since the last green (same JSON content). |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |

Stacked on #622 (launch discount). Review only this PR's commit. It rebases onto danish-law's offerings PR with the stack.
The maintainer approved a standard set of add-ons. This PR adds them to the catalogue and lets clients order them in the portal, behind the existing order gates. The public listing under the offers follows in its own PR on top of danish-law's price change, which touches the same public copy.
Catalogue (
addonsinofferings.json)Each add-on has an id, a kind (
one-timeormonthly), a VAT-inclusive price in whole kroner, the offerings it fits, an optional unit limit (max) and EN/DA text. The portal refuses to start with an add-on it cannot sell.priority400 andexpress1000 (tiers; at most one per order);statistics75 (website, app);email100.language1500 per language, up to 5 (website, app);contact-form1500 (website, app);payments3000 (website, app);news2500 (website);accounts4000 (app only);migration1500 (website);seo1000 (website, app).The cut add-ons (test version, extra storage, booking, integrations, accessibility check, logo kit) are not in the catalogue and stay fixed quotes.
Ordering and billing
portal_order_addons, migration v25). The order's one-time and monthly prices include them, so funding, withdrawals and settlements are unchanged. The launch discount takes off the proposal's own one-time price only.AGENTS.mdnow says: a request outside the offer becomes anaddon-candidateissue that describes only the request, never the customer. The label is declared in feat(labels): add the addon-candidate label to business-site .github#947, merged, and the monthly review is monorepo#5085, merged.Tests
TestAddon*:Mutation checks on the invoice lines and the retry rule are load-bearing. The full Go suite passes, and golangci-lint, vet, gofmt, jscpd and cspell are clean.
Part of #21
🤖 Generated with Claude Code