Repository navigation
ci: adopt the template's shared lint, CodeQL, CodeRabbit and Renovate config - #480
Conversation
… config Take the application template's current shared files so the next template-sync is nearly empty, add the MegaLinter job to the required checks, and add this tenant's overlays (.mega-linter.yml, .github/codeql/codeql-config.yml) to .templatesyncignore with the template-only scaffold and stacks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stylelint learns Tailwind v4's @import string and at-rules in a repo .stylelintrc.json, the theme's two groups get comments instead of a bare blank line, and the HEALTHCHECK uses JSON notation with the same shell command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The HEALTHCHECK asked for localhost, which resolves to ::1 inside the image while the server listens on IPv4, so it was refused and the container never reported healthy; ask 127.0.0.1. Also satisfy hadolint: the numeric user (the node user, as deploy/ already runs it) and one build RUN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai full review |
Action performed
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
What
Onboards this tenant onto the application template's shared configuration (monorepo ADR 0018, 2026-11-15 amendment; epic devantler-tech/monorepo#5062). It takes the template's current shared files, so the next template-sync is nearly empty:
.github/workflows/lint.yaml(MegaLinter cupcake, read-only) and.github/mega-linter.base.yml,.markdownlint.json,.yamllint.yml. A newmegalinterjob inci.yamlcalls it and counts towardsCI - Required Checks. The existinglintjob (ESLint) stays; MegaLinter leaves JavaScript and TypeScript to it..github/workflows/codeql.yaml(advanced setup, languages detected from the files). It stays off until the maintainer turns CodeQL default setup off and setsCODEQL_SETUP=advanced..coderabbit.yaml, layered over the organization's settings.renovate.jsonfor the image tags indeploy/only; Dependabot keeps everything else. It does nothing until the repository is enrolled in Renovate.release.yaml,template-sync.yaml,stale-issues.yamlandcd.yamlmove to the template's content: the repository-ID guard and thedevantler-tech/.githubv21.6.2 callers. Thepublish-apppin is unchanged..mega-linter.yml(extends the base) and.github/codeql/codeql-config.yml, both now in.templatesyncignore, with the template-onlystacks/,scripts/scaffold.sh(+ test) andvalidate-stacks.yaml.Nothing is diverged from: every shared file is taken as the template has it.
Fixes the first MegaLinter run asked for
.stylelintrc.jsonextendsstylelint-config-standardand allows Tailwind v4's string@importand its at-rules (@theme,@source,@utilityand the rest), which stylelint does not know.src/app.csslabels the theme's colour and font groups with comments, which keeps the blank line between them.DockerfileHEALTHCHECKuses JSON notation (hadolint DL3025) and asks127.0.0.1instead oflocalhost: inside the imagelocalhostresolves to::1first while the server listens on IPv4, so the old check was refused and the container never reported healthy. The runtime stage runs asUSER 1000(the samenodeuser, by number, asdeploy/already sets) and the build stage runs build and prune in oneRUN.Validation
actionlintandzizmorclean on.github/workflows/;scripts/workflow-caller-pin-contract.test.shpasses.stylelintpasses onsrc/app.csswith the new config (and still flags the original file, so the config is read);hadolintis clean. The image builds, servesGET /login200 read-only with all capabilities dropped as UID 1000, reportshealthy, and exits 0 on SIGTERM.Maintainer-only switches
CODEQL_SETUPtoadvanced.🤖 Generated with Claude Code