reworking Be assembly example - #12
Open
eepeterson wants to merge 4 commits into
Open
Conversation
eepeterson
requested review from
Ebiwonjumi,
SteSeg,
paulromano and
pshriwise
February 28, 2023 19:22
pshriwise
requested changes
Mar 1, 2023
pshriwise
left a comment
Collaborator
There was a problem hiding this comment.
Looks pretty nice! Just a few line comments from me.
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Collaborator
|
The reasons why I initially had the inputs in three places for the flux, reaction rates and gamma heating are: (1) didn't check yet if the trace nuclides I added in the _reaction_rate input would affect the flux significantly; It is best to have one input file for all tallies as you have done. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a streamlined version of the great work @Ebiwonjumi put in on #10 for only the
fns_bepart since that was the first one I saw in the PR. I saw that there were a number of copy/pasted model generating files, but for each benchmark I would like to have a single openmc python API input. I'm hoping the rework here offns_be_build_xml.py,fns_be_build_xml_gh.py, andfns_be_build_xml_rxn_rate.pyinto a singlefns_be.pyfile makes sense to people. There are a couple things I want to highlight about this approach below:I haven't yet checked whether this gives us identical results as what @Ebiwonjumi has been showing so that would be something else we need to do and having a single output parsing script for each benchmark would help with this.
Once this is reviewed and merged, we can divvy up some of the other benchmarks and rework them into this format, but I think it is worth spending some time iterating on whether this is the right way we want to handle this before spending more time reworking inputs. I would appreciate input from everyone if they have the time so we can figure out a uniform way to proceed. @Ebiwonjumi @SteSeg @paulromano @pshriwise.