Repository navigation
op-acceptance-tests,op-devstack,op-service: check the Isthmus withdrawals root across persistence runs - #23438
Conversation
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
a307188 to
ae5d1e9
Compare
530218f to
458fd57
Compare
ae5d1e9 to
a43a3c9
Compare
458fd57 to
2fc40d6
Compare
|
Claude: Detail moved out of the PR description when the branch was squashed into 2fc40d6. It is the description as it stood before the squash, unedited, so it describes the earlier commits. Since Isthmus a block's What the test covers
Matrix: threshold {7, 50} x masking {0, 30} as subtests ( Local verificationDebug op-reth built from this branch, kona-node release binary built from op-node (default): Threshold 7: 96 withdrawals in blocks 22–45, 24 of 24 blocks with a withdrawal, longest gap 0. Threshold 50: 440 withdrawals in blocks 22–131, 110 of 110 blocks with a withdrawal, longest gap 0. Both sweeps (right after the run, and once every node was threshold + 5 blocks past the run's last block) passed on all four nodes in both cells. A sweep itself takes about 0.1 s per 24 blocks and 1 s per 110 blocks; the phases are separated by the wait for the chain, not by the checks. kona-node ( Threshold 7: blocks 26–49, 24 of 24 with a withdrawal. Threshold 50: blocks 26–135, 110 of 110 with a withdrawal. Longest gap 0 in both. Against #23046's op-reth (reth 2.6.0, the debug binary built from the bump head 93d9ec9 for #23436; op-node), same command: both running cells pass, so this check holds on the bump as well: Threshold 7: blocks 22–45, 24 of 24 with a withdrawal. Threshold 50: blocks 22–131, 110 of 110 with a withdrawal. Longest gap 0 in both. The kona-node cells were not run against the bump. Unit test of the run summary ( Skipped cells
Findings
Seams added
Notes on the issue textThe issue lists three nodes (sequencer, op-reth follower without proofs history, op-geth follower); the test also runs an op-reth follower with proofs history, so the proofs-history store is covered against an independent op-reth reference across the same persistence runs, and it also checks Stacked on #23436, #23431, #23427, #23421 and #23418. Closes #23398 |
2fc40d6 to
f4c7010
Compare
a43a3c9 to
b7ab15e
Compare
f4c7010 to
be963b4
Compare
47f5a25 to
d9a8102
Compare
be963b4 to
5b3e133
Compare
d9a8102 to
55f06d3
Compare
5b3e133 to
63096fc
Compare
55f06d3 to
924225b
Compare
63096fc to
5fe7487
Compare
924225b to
a8c5f35
Compare
5fe7487 to
4c4f1fb
Compare
|
🤖 Fable says: A note from the op-geth decoupling work (#20257). The new test here starts an op-geth follower ( op-geth is EOL as of Karst, and #21744 removes the in-process op-geth L2 EL from op-devstack/sysgo ( Can the follower be op-reth instead? |
…wals root across persistence runs Adds an acceptance test that initiates withdrawals from four accounts in every block for twice as many blocks as reth holds in memory, under thresholds 7 and 50, and requires every block of the run to carry as its withdrawalsRoot the L2ToL1MessagePasser storage root that eth_getProof serves on the op-reth sequencer and an op-geth follower, with a proofs-history follower swept against an op-reth follower reading its own historical state, and every node on the sequencer's chain. The first sweep runs with sequencing stopped within reth's memory buffer of the run's last block, once the run's first block is persisted; the second runs once every op-reth node reports, through reth_subscribePersistedBlock, that it persisted the whole run. The test asserts that the run crossed a persistence boundary, that no gap between blocks with a withdrawal spans a whole persistence run, and that at least four in five blocks carry one. The op-geth follower runs a genesis without Karst, which op-geth v1.101702.4-rc.2 refuses. Adds the DSL check that a block's withdrawalsRoot is the message passer's storage root the node proves against the header's state root, a tracker of reth's persisted block on top of a new client.SubscribeWS, and L2ELNode.NonceAt. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a8c5f35 to
055c21b
Compare
4c4f1fb to
19b45d1
Compare
Since Isthmus
withdrawalsRootis the message passer's storage root, computed through overlay state providers that reth 2.6 rewrites, and no test checked it with persistence engaged.Initiates withdrawals in every block for twice reth's in-memory window under thresholds 7 and 50, and requires every block's
withdrawalsRootto equal the message passer storage root proven by the sequencer, an op-reth follower, an op-geth follower and a proofs-history follower: once with sequencing stopped while the newest blocks are still in reth's memory, and again once every op-reth node reports (viareth_subscribePersistedBlock) that it persisted the run.Stacked on #23436. Closes #23398. Local verification, findings and notes: detail comment.
Breakdown
AI Reviews
<ISODATETIME><COMMITID>Fable 5.1 xhigh<ISODATETIME><COMMITID>GPT-6.1-Sol xhigh<ISODATETIME><COMMITID>Opus 5.5 xhigh🤖 Generated with Claude Code