Repository navigation
Conversation
Bumps the reth pin to ethereum-optimism/reth#18, which replays block transactions through the block executor so debug_trace*, trace_*, eth_callMany/debug_traceCall at an index/debug_traceCallMany and debug_intermediateRoots report canonical gas and settled balances on SDM blocks. Extends debug_trace_post_exec.rs with a sequenced SDM block that checks each path against the receipt, committed state and header. Ref: ethereum-optimism/protocol-team#485 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pins the deployment's absolute canonical gas, requires the sender balance to change in every state diff, checks replay lengths, and moves the Lagoon chain spec and payload attributes into a module shared with invalid_post_exec.rs. Rewords two alloy-op-evm comments that described RPC replay as bypassing the block executor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
…settlement-v2.6.0 # Conflicts: # rust/Cargo.lock # rust/Cargo.toml
This was referenced Oct 20, 2026
ethereum-optimism/reth#24 keeps debug_traceBlock on a bare EVM so blocks the executor rejects still trace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Superseded by #23670, which settles SDM refunds through the replay hooks in ethereum-optimism/reth#26. Tracked in ethereum-optimism/protocol-team#485. Closing as superseded; branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SDM blocks, the RPC paths that replay a block's transactions report the pre-refund result:
debug_traceTransaction/debug_traceBlockByHash/debug_traceBlockByNumberreturn pre-refund gas and state diffs that charge the sender refund × price too much,trace_*state diffs andeth_callMany/debug_traceCallat an index /debug_traceCallManystart from unsettled balances, anddebug_intermediateRootsnever reaches the header's state root. Explorers and indexers ingest those numbers. With this PR every one of those paths agrees with the receipt, the committed balances and the header. Consensus, receipts and stored state are unaffected.The settlement lives only in the block executor and the replay helpers live in reth, so the fix is ethereum-optimism/reth#24 (replay through the executor) and this PR pins it.
debug_trace_post_exec.rsnow sequences a real SDM block with the fixed test policy and checks each path; it fails on the current pin (every path off by exactly the refund × price split) and passes on this one.debug_traceBlock(raw RLP) anddebug_traceBadBlockstay on a bare EVM, so blocks the executor would reject still trace, and they keep reporting pre-refund gas for blocks with refunds, as ondeveloptoday. The raw-block test now pins that.Part of ethereum-optimism/protocol-team#485. The issue's last item — whether production SDM opt-in waits for RPC fleets to run this — is still open.
Do not merge yet: the pin is the head of the unmerged reth#24. Once it merges into the fork's
op-v2.6.0branch, repin allrust/Cargo.tomlentries to the resulting tag or commit and advance theUPSTREAM-MIRRORtags to it. optimism-premium pins the same reth rev and must move to that commit in step with itsoptimism_rev.Behaviour change that comes with the fork change: replay errors on the executor paths map through
BlockExecutionError, so their RPC error codes change. It isn't reachable when replaying a canonical block.Review findings dismissed (please confirm):
eth_callMany,debug_traceCallMany,trace_block/trace_filterandots_getTransactionErrorare not exercised directly. They sharereplay_block_until,trace_block_until_with_inspectorandspawn_replay_transactionwith paths the test covers.invalid_post_exec.rsuses free helpers.🤖 Generated with Claude Code