Repository navigation
Conversation
The RPC helpers that replay a block's own transactions without a cached BAL ran them on a bare EVM, so per-transaction changes the block executor applies, such as OP Stack's post-execution gas refunds, were missing from traces, replayed state and intermediate roots. Those replays, canonical block tracing and traceChain now go through the executor. The cached-BAL paths are unchanged, and raw and bad block tracing keeps the bare EVM so blocks the executor rejects still trace. alloy-evm's `TxTracer` can't drive an executor, so `trace_block_until_with_inspector` has its own loop and a local `TracingCtx` that borrows the result. `replay_transactions_until_with_evm` has no callers left and is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Collaborator
Author
|
Upstream: paradigmxyz#28047 (draft, same change on upstream main). |
geoknee
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Oct 23, 2026
ethereum-optimism/reth#24 keeps debug_traceBlock on a bare EVM so blocks the executor rejects still trace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
geoknee
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Oct 23, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
|
Superseded by #26, which exposes replay hooks without changing replay behavior for other chains; the OP settlement lives in ethereum-optimism/optimism#23670. Tracked in ethereum-optimism/protocol-team#485. Closing as superseded; branch kept. |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #23 with a narrower change that leaves Ethereum behavior and the cached-BAL fast path alone.
The RPC helpers that replay a block's own transactions without a cached BAL now run them through the block executor instead of a bare EVM, so
debug_traceTransaction,debug_traceBlockByHash/ByNumber,traceChain,trace_*,ots_*,debug_traceCall/eth_callManyat a transaction index anddebug_intermediateRootsinclude the per-transaction changes the executor applies, such as OP Stack's post-execution gas refunds. When a cached BAL is available the target transaction still runs on its own, as upstream does since paradigmxyz#24097; op-reth never caches one, because it rejects the BAL options and serves none of the BAL RPCs.debug_traceBlock(raw RLP) anddebug_traceBadBlockkeep the bare EVM so blocks the executor would reject still trace, which means they report pre-refund gas for OP blocks with refunds. Method signatures are unchanged except thattrace_block_until*callbacks get a localTracingCtxwith the same fields and a borrowedresult, since alloy-evm's can't be built from an executor;replay_transactions_until_with_evm, which has no callers left, is removed.On Ethereum the executor only adds the block gas checks, receipt building and gas totals on top of the EVM, so results for valid blocks are unchanged.
reth-rpc,reth-rpc-eth-api,reth-node-ethereum(includingtest_bal_prewarming_for_transaction_replay, which reaches the BAL path again) andreth-rpc-e2e-teststests pass, and fmt, clippy and rustdoc with-D warningsare clean. With op-reth pinned to this commit, the ethereum-optimism/optimism#23465 suite passes once its raw-block test expects pre-refund gas instead of canonical gas.🤖 Generated with Claude Code