Repository navigation
Conversation
Move the per-block replay loops behind defaulted `Trace` methods so an `EthApi` whose block executor keeps per-transaction state can replay through it: `trace_block_transactions` (backing `trace_block_until_with_inspector`), `debug_trace_block_transactions`, `debug_trace_chain_block_transactions` and `block_intermediate_roots`. The bodies are unchanged. Callbacks get a reth-owned `TracingCtx` that can be constructed outside the crate, since alloy-evm's can't; it borrows the execution result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
|
Superseded by #26, which derives from this extension-point design with explicit canonical versus diagnostic replay and an owned callback result. Tracked in ethereum-optimism/protocol-team#485. Closing as superseded; branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the per-block replay loops behind defaulted
Tracemethods, so anEthApiwhose block executor keeps per-transaction state can replay blocks through the executor instead of a bare EVM:trace_block_transactions(backingtrace_block_until_with_inspector, so thetrace_*andots_*block traces),debug_trace_block_transactions(debug_traceBlock*,debug_traceBadBlock),debug_trace_chain_block_transactions(traceChain) andblock_intermediate_roots(debug_intermediateRoots). The bodies are moved unchanged, so behavior is the same on every chain.Block-trace callbacks get a reth-owned
TracingCtxwith a public constructor, because alloy-evm's has private fields and can only be built by itsTxTracer; the default loop keepsTxTracer's semantics. The context borrows the execution result instead of owning it.This is the reth half of the plan in ethereum-optimism/protocol-team#485: op-reth overrides these methods to settle SDM refunds, and the change is a candidate for upstream. Supersedes #24 for that purpose.
🤖 Generated with Claude Code