[Refactoring] Improve FileNotFoundError message in PointNavDatasetV1 - #2197
Open
anlorla wants to merge 1 commit into
Open
[Refactoring] Improve FileNotFoundError message in PointNavDatasetV1#2197anlorla wants to merge 1 commit into
anlorla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When either
data_pathorscenes_diris missing,PointNavDatasetV1.get_scenes_to_loadraises aFileNotFoundErrorthat only prints the dataset directory.This can mislead users into focusing on
data_pathwhile the real issue is oftenscenes_dir.This PR refactors the error message to display both
data_path(expanded withsplit) andscenes_dirto improve debuggability.How Has This Been Tested
data_pathand an invalidscenes_dir; verified the new message includes both paths and clearly indicates the missing one.Types of changes
Checklist
Before / After
Before
FileNotFoundError: Could not find dataset file <dataset_dir>After