Skip to content

[Refactoring] Improve FileNotFoundError message in PointNavDatasetV1 #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anlorla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Refactoring] Improve FileNotFoundError message in PointNavDatasetV1 #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions habitat-lab/habitat/datasets/pointnav/pointnav_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,15 @@ class PointNavDatasetV1(Dataset):
content_scenes_path: str = "{data_path}/content/{scene}.json.gz"

@staticmethod
def check_config_paths_exist(config: "DictConfig") -> bool:
return os.path.exists(
config.data_path.format(split=config.split)
) and os.path.exists(config.scenes_dir)
def check_config_paths_exist(config):
data_path = config.data_path.format(split=config.split)
if not os.path.exists(data_path):
raise FileNotFoundError(f"Could not find data_path: {data_path}")
if not os.path.exists(config.scenes_dir):
raise FileNotFoundError(
f"Could not find scenes_dir: {config.scenes_dir}"
)
return True

@classmethod
def get_scenes_to_load(cls, config: "DictConfig") -> List[str]:
Expand All @@ -50,7 +55,9 @@ def get_scenes_to_load(cls, config: "DictConfig") -> List[str]:
)
if not cls.check_config_paths_exist(config):
raise FileNotFoundError(
f"Could not find dataset file `{dataset_dir}`"
"Dataset paths not found.\n"
f" data_path: {config.data_path.format(split=config.split)}\n"
f" scenes_dir: {config.scenes_dir}"
)

cfg = config.copy()
Expand Down