feat(metadata): add advanced metadata editing - #137
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tagium | 17ff983 | Commit Preview URL Branch Preview URL |
Aug 03 2026, 07:54 PM |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This was referenced Jul 24, 2026
flamboh
force-pushed
the
agent/advanced-metadata-editing
branch
from
July 25, 2026 08:45
eacbf56 to
f1a3d60
Compare
…a-linking-transition # Conflicts: # src/features/export/useExportSession.ts
flamboh
marked this pull request as ready for review
August 3, 2026 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This rebuild combines the product intent of #122 and #124 on top of the merged multi-format engine from #129. It replaces the old MP3-specific write architecture with format-driver support and keeps format branching behind the existing metadata engine seam.
Replacement
Replaces #122 and #124 as one PR. #119 is already superseded by #129 and is not included.
The implementation was built in two stages (engine/policy, then UI) and passed independent foundation, UI, whole-PR, and targeted data-safety reviews.
Data safety
Human review
mainshould still open and complete normally.Worth checking: reduced-motion should remove the disclosure, switch, and field-pane transitions; album title remains permanently linked; unlinking a tag makes it track-local while linked tags continue to follow album changes.
The main product tradeoff is deliberate: Advanced controls are hidden by default, but their values and linking choices are retained when Advanced is disabled.
Verification
bun run typecheckbun run lint— 0 warnings/errorsbun run test— 106 files, 674 tests passedbun run buildgit diff --checkPlaywright/live visual verification was not run because no dev server was already available and project instructions prohibit starting one for this workflow.