Skip to content

feat(metadata): add advanced editor - #124

Closed
flamboh wants to merge 13 commits into
codex/metadata-policy-corefrom
codex/advanced-metadata-ui
Closed

flamboh wants to merge 13 commits into
codex/metadata-policy-corefrom
codex/advanced-metadata-ui

Conversation

@flamboh

@flamboh flamboh commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a Settings-gated Advanced mode for album artist, disc number, composer, BPM, and comments
  • swap the editor between normal and advanced metadata views
  • keep album artist linked by default and honor metadata-link policy
  • expose track-number syncing exactly once under General settings

Projection safety

  • centralize advanced numeric validation for preview, single-track, album, and library projections
  • prevent invalid disc/BPM values from entering pending patches, materialized files, bulk exports, direct writes, or hydration recovery
  • distinguish malformed NaN/present undefined from intentional null clears
  • preserve last-valid/parsed metadata and unrelated valid pending edits across success and write-error paths

Verification

  • vp check
  • bun run typecheck
  • bun run test (443 tests)
  • bun run build
  • two fresh reviewers plus repeated rechecks through form, pending-patch, direct-write, and hydration edge cases

Dependency

Targets #122 (codex/metadata-policy-core).

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit ca4e774.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium ca4e774 Commit Preview URL

Branch Preview URL
Jul 23 2026, 04:56 AM

@flamboh
flamboh force-pushed the codex/metadata-policy-core branch from a0add6f to b8109a8 Compare July 17, 2026 13:24
@flamboh
flamboh force-pushed the codex/advanced-metadata-ui branch from 5f984ca to f630a5a Compare July 17, 2026 13:25

flamboh commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

@flamboh

flamboh commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded together with #122 by the combined advanced metadata rebuild in #137.

@flamboh flamboh closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant