Skip to content

refactor(audio): make formats explicit - #119

Closed
flamboh wants to merge 2 commits into
mainfrom
codex/format-aware-audio-core
Closed

flamboh wants to merge 2 commits into
mainfrom
codex/format-aware-audio-core

Conversation

@flamboh

@flamboh flamboh commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • add authoritative AudioFormat identity to every TagiumFile
  • centralize MP3 extension, MIME, admission hint, filename, and output helpers
  • route hard-coded naming behavior through the format module across import, editor, cleanup, hydration, and export
  • keep metadata parsing/writing behind the existing AudioMetadataIO seam with no premature adapter registry
  • add format-helper and metadata-I/O seam coverage for misleading MIME/extensions and filename preservation

Why

FLAC support needs format identity and naming rules to be explicit before a second format can safely enter the system. This PR is behavior-preserving for MP3 and does not add or advertise FLAC.

Verification

  • bun run typecheck
  • bun run lint
  • 322 unit tests passed
  • 78 focused affected tests passed
  • two fresh independent reviews passed with no findings
  • full suite reached 393 passing; 6 server proxy tests could not bind 127.0.0.1 in the sandbox (EPERM)
  • git diff --check

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium 3e2721e Commit Preview URL

Branch Preview URL
Jul 17 2026, 01:24 PM

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 3e2721e.

@flamboh

flamboh commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #129, which merged the current lossless multi-format metadata engine.

@flamboh flamboh closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant