Skip to content

feat(ui): polish workspace states - #120

Closed
flamboh wants to merge 3 commits into
codex/advanced-metadata-uifrom
codex/workspace-polish
Closed

flamboh wants to merge 3 commits into
codex/advanced-metadata-uifrom
codex/workspace-polish

Conversation

@flamboh

@flamboh flamboh commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • reuse one clickable/drop audio-import surface on home and in the no-selection editor state
  • move the media URL entry between landing, empty-editor, and loaded-editor layouts, and fully unmount it in Settings
  • disable invalid album create/save actions with accessible required-field and processing semantics
  • make checkbox labels non-selectable
  • show track-saved feedback only for three seconds, with timer cleanup and a separate polite live-region announcement
  • add focused dropzone, form-state, transition, timer, and accessibility tests

Why

These related polish fixes remove a dead-end editor state, eliminate Settings layout residue, prevent invalid album submissions, and make transient download feedback behave consistently.

Verification

  • bun run typecheck
  • bun run lint — 0 warnings/errors
  • bun run test — 64 files, 401 tests passed
  • git diff --check
  • two fresh independent reviews; all findings resolved and re-reviewed

Playwright was not run because its configuration starts a development server, which this repository’s manual-review instructions prohibit for this workflow.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium 374e591 Commit Preview URL

Branch Preview URL
Jul 23 2026, 04:56 AM

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 374e591.

@flamboh
flamboh changed the base branch from main to graphite-base/120 July 20, 2026 20:41
@flamboh
flamboh force-pushed the codex/workspace-polish branch from 305c642 to 9bd6474 Compare July 20, 2026 20:41
@flamboh
flamboh changed the base branch from graphite-base/120 to codex/advanced-metadata-ui July 20, 2026 20:42

flamboh commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

@flamboh

flamboh commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the clean rebuild in #135.

@flamboh flamboh closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant