Skip to content

feat(metadata): reopen cleanup suggestions - #121

Closed
flamboh wants to merge 2 commits into
codex/workspace-polishfrom
codex/cleanup-reentry
Closed

flamboh wants to merge 2 commits into
codex/workspace-polishfrom
codex/cleanup-reentry

Conversation

@flamboh

@flamboh flamboh commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • derive current title-cleanup suggestions per album
  • show an accessible album warning action with an “apply edits?” tooltip only while suggestions exist
  • reopen the existing cleanup dialog scoped to the selected album
  • preserve user checkbox choices across equivalent live recomputations and background busy transitions
  • keep dismissal stateless; applying, undoing, and later title edits naturally recompute warning state
  • add focused sidebar, dialog, cleanup, and workspace-hook regression coverage

Why

The initial cleanup toast was easy to dismiss permanently. Albums with unapplied suggestions now retain a discoverable, current re-entry point without persisting duplicate suggestion state.

Verification

  • post-rebase bun run typecheck
  • post-rebase bun run lint — 0 warnings/errors
  • post-rebase bun run test — 66 files, 401 tests passed
  • git diff --check
  • two fresh independent reviews; findings fixed and re-reviewed

This branch was rebased onto origin/main after implementation, so the PR is independently mergeable and does not include PR #120.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit a6c324d.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium a6c324d Commit Preview URL

Branch Preview URL
Jul 23 2026, 04:56 AM

@flamboh
flamboh changed the base branch from main to graphite-base/121 July 20, 2026 20:41
@flamboh
flamboh force-pushed the codex/cleanup-reentry branch from 81a1594 to a93d769 Compare July 20, 2026 20:41
@flamboh
flamboh changed the base branch from graphite-base/121 to codex/workspace-polish July 20, 2026 20:42

flamboh commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

@flamboh

flamboh commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the album context-menu cleanup re-entry rebuild in #136.

@flamboh flamboh closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant