Skip to content

feat(export): confirm bulk downloads - #123

Closed
flamboh wants to merge 10 commits into
codex/cleanup-reentryfrom
codex/export-confirmation
Closed

flamboh wants to merge 10 commits into
codex/cleanup-reentryfrom
codex/export-confirmation

Conversation

@flamboh

@flamboh flamboh commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • confirm album and library downloads before analytics, metadata writes, ZIP creation, or browser download
  • show album-grouped counts and current-file byte estimates with expandable per-track details and explicit loose-track grouping
  • keep single-track downloads immediate
  • consolidate album/library execution into one target-driven pipeline
  • revalidate complete export-affecting state before confirm, announce stale/unavailable changes, and require explicit reconfirmation
  • guard double confirmation, busy dismissal, empty albums, and stale ready→unready transitions
  • focus Cancel initially and restore focus to the initiating download control
  • use bounded artwork fingerprints rather than serializing binary cover data
  • add unit and Playwright interaction coverage

Why

Bulk downloads can include many files and significant data. This makes scope and estimated size inspectable without adding friction to single-track export.

Verification

  • post-rebase bun run typecheck
  • post-rebase bun run lint — 0 warnings/errors
  • post-rebase bun run test — 65 files, 414 tests passed
  • git diff --check
  • two fresh independent reviews; all correctness, focus, stale-state, and performance findings fixed and re-reviewed

The Playwright interaction spec covers mounted focus, Escape/outside dismissal, restoration, and constrained mobile scrolling. It was typechecked but not executed because no server was already listening and repository instructions prohibit starting a dev server for this workflow.

This branch was rebased onto origin/main and is independently mergeable.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit f8af51f.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium f8af51f Commit Preview URL

Branch Preview URL
Jul 23 2026, 04:56 AM

@flamboh
flamboh changed the base branch from main to graphite-base/123 July 20, 2026 20:41
@flamboh
flamboh force-pushed the codex/export-confirmation branch from 1db2baa to 97ad719 Compare July 20, 2026 20:41
@flamboh
flamboh changed the base branch from graphite-base/123 to codex/cleanup-reentry July 20, 2026 20:42

flamboh commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

@flamboh
flamboh force-pushed the codex/export-confirmation branch from 756c6a3 to f8af51f Compare July 23, 2026 04:55
@flamboh
flamboh force-pushed the codex/cleanup-reentry branch from 5eaa55b to a6c324d Compare July 23, 2026 04:55
@flamboh

flamboh commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the clean export confirmation rebuild in #138.

@flamboh flamboh closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant