Skip to content

feat(metadata): add advanced field policy - #122

Closed
flamboh wants to merge 1 commit into
codex/format-aware-audio-corefrom
codex/metadata-policy-core
Closed

flamboh wants to merge 1 commit into
codex/format-aware-audio-corefrom
codex/metadata-policy-core

Conversation

@flamboh

@flamboh flamboh commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • add album artist, disc number, composer, BPM, and comment across metadata snapshots, sparse patches, hydration, editor sessions, export, and MP3 I/O
  • add an off-by-default Advanced Metadata gate and one backward-compatible global metadata-link policy
  • centralize album-to-track policy application for album operations, imports, moves, cover/number sync, hydration, and export
  • preserve current library values when settings change; apply policy only at defined future synchronization/write seams
  • preserve unknown ID3v2 frames, alternate comments, and byte-identical audio payloads during real mp3tag.js round trips
  • upgrade untagged/ID3v1 inputs to ID3v2.4 when advanced fields require it
  • add real-codec and policy regression coverage

Why

Advanced editor controls need a behavior-preserving metadata and synchronization foundation. This PR keeps visible behavior unchanged while making link semantics and advanced field persistence explicit.

Verification

  • post-commit bun run typecheck
  • post-commit bun run lint — 0 warnings/errors
  • post-commit bun run test — 65 files, 412 tests passed
  • git diff --check
  • two fresh independent reviews; all data-loss and hydration findings fixed and re-reviewed

Known format constraint

Album artist, composer, BPM, and disc number have no ID3v1 representation. When they are written to an ID3v1-only or untagged MP3, Tagium adds ID3v2.4 while preserving the audio payload.

This PR intentionally targets codex/format-aware-audio-core (PR #119); its format identity and naming seam are a genuine dependency.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium b8109a8 Commit Preview URL

Branch Preview URL
Jul 17 2026, 01:25 PM

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit b8109a8.

@flamboh
flamboh force-pushed the codex/metadata-policy-core branch from a0add6f to b8109a8 Compare July 17, 2026 13:24

flamboh commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

@flamboh

flamboh commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Superseded together with #124 by the combined advanced metadata rebuild in #137.

@flamboh flamboh closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant